Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 962633002: scheduler: Convert enums to enum classes (Closed)

Created:
5 years, 10 months ago by Sami
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Convert enums to enum classes Convert enums to enum classes to make their purpose clearer and to make it easier to expose them to the unit tests. Note that the task queue identifier is maintained as a numeric enum because it serves as an index to the task queue manager and selector. No functional changes. Committed: https://crrev.com/16ebe5b1584ec660893f8890f21a6c1d5cab80fe Cr-Commit-Position: refs/heads/master@{#318248}

Patch Set 1 #

Patch Set 2 : Did the rest too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -79 lines) Patch
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 1 13 chunks +32 lines, -30 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.h View 1 2 chunks +8 lines, -11 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager.cc View 1 10 chunks +23 lines, -21 lines 0 comments Download
M content/renderer/scheduler/task_queue_manager_unittest.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sami
5 years, 10 months ago (2015-02-26 14:45:35 UTC) #2
alex clarke (OOO till 29th)
lgtm
5 years, 10 months ago (2015-02-26 14:54:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962633002/20001
5 years, 10 months ago (2015-02-26 14:56:07 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 16:27:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 16:28:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16ebe5b1584ec660893f8890f21a6c1d5cab80fe
Cr-Commit-Position: refs/heads/master@{#318248}

Powered by Google App Engine
This is Rietveld 408576698