Update permission bubble anchor when omnibar is hidden

ui/views/bubble/bubble_delegate.cc

Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index 55ce980289149c322219d60e35222009d4ee8614..68c35f2b2eb94acd048510abfc07ed808997aaac 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -96,7 +96,16 @@ BubbleDelegateView::~BubbleDelegateView() {
 Widget* BubbleDelegateView::CreateBubble(BubbleDelegateView* bubble_delegate) {
   bubble_delegate->Init();
   // Get the latest anchor widget from the anchor view at bubble creation time.
-  bubble_delegate->SetAnchorView(bubble_delegate->GetAnchorView());
+  views::View* anchor = bubble_delegate->GetAnchorView();

[hcarmona, 2015/02/28 00:24:53]

Trybots hated this check. I'm removing it.

Are there cases where we should not be showing the anchor view or do we have a
lot of potential bugs?

[groby-ooo-7-16, 2015/02/28 00:26:22]

This statement does not make sense to me. What check are you removing? Which
bugs are you referring to?

[hcarmona, 2015/02/28 01:14:16]

I added the DCHECK on line 105 to avoid having a bubble with an arrow when the
anchor is invisible. This condition seems like something undesirable because
we'll have a bubble with an arrow pointing at an invisible view.

I removed the change to this file to avoid breaking a lot of tests.

My question is: will we be missing UI bugs by not verifying that all bubbles
with an anchor have an arrow? An example of an issue that would be caught by
this is crbug.com/462087

+  BubbleBorder::Arrow arrow = bubble_delegate->arrow();
+
+  // Anchor should always be visible when it has an arrow to avoid accidentally
+  // showing a bubble with an arrow when the anchor is not visible.
+  // ex: Bubble is anchored to lock button in omnibar while in fullscreen.
+  DCHECK(arrow == BubbleBorder::NONE || arrow == BubbleBorder::FLOAT ||

[groby-ooo-7-16, 2015/02/28 00:25:12]

Why verify this here, and not in the bubble where we draw it and need to access
both arrow and anchor anyways?

[hcarmona, 2015/02/28 01:14:16]

We can verify when drawing the bubble, but I imagine the trybots will be equally
upset.

+         anchor->IsDrawn());
+
+  bubble_delegate->SetAnchorView(anchor);
   Widget* bubble_widget = CreateBubbleWidget(bubble_delegate);
 
 #if defined(OS_WIN)