Update permission bubble anchor when omnibar is hidden

ui/views/bubble/bubble_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_delegate.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/geometry/rect.h"
@@ skipping 78 matching lines @@
   if (GetWidget())
     GetWidget()->RemoveObserver(this);
   SetLayoutManager(NULL);
   SetAnchorView(NULL);
 }
 
 // static
 Widget* BubbleDelegateView::CreateBubble(BubbleDelegateView* bubble_delegate) {
   bubble_delegate->Init();
   // Get the latest anchor widget from the anchor view at bubble creation time.
-  bubble_delegate->SetAnchorView(bubble_delegate->GetAnchorView());
+  views::View* anchor = bubble_delegate->GetAnchorView();

[hcarmona, 2015/02/28 00:24:53]

Trybots hated this check. I'm removing it.

Are there cases where we should not be showing the anchor view or do we have a
lot of potential bugs?

[groby-ooo-7-16, 2015/02/28 00:26:22]

This statement does not make sense to me. What check are you removing? Which
bugs are you referring to?

[hcarmona, 2015/02/28 01:14:16]

I added the DCHECK on line 105 to avoid having a bubble with an arrow when the
anchor is invisible. This condition seems like something undesirable because
we'll have a bubble with an arrow pointing at an invisible view.

I removed the change to this file to avoid breaking a lot of tests.

My question is: will we be missing UI bugs by not verifying that all bubbles
with an anchor have an arrow? An example of an issue that would be caught by
this is crbug.com/462087

+  BubbleBorder::Arrow arrow = bubble_delegate->arrow();
+
+  // Anchor should always be visible when it has an arrow to avoid accidentally
+  // showing a bubble with an arrow when the anchor is not visible.
+  // ex: Bubble is anchored to lock button in omnibar while in fullscreen.
+  DCHECK(arrow == BubbleBorder::NONE || arrow == BubbleBorder::FLOAT ||

[groby-ooo-7-16, 2015/02/28 00:25:12]

Why verify this here, and not in the bubble where we draw it and need to access
both arrow and anchor anyways?

[hcarmona, 2015/02/28 01:14:16]

We can verify when drawing the bubble, but I imagine the trybots will be equally
upset.

+         anchor->IsDrawn());
+
+  bubble_delegate->SetAnchorView(anchor);
   Widget* bubble_widget = CreateBubbleWidget(bubble_delegate);
 
 #if defined(OS_WIN)
   // If glass is enabled, the bubble is allowed to extend outside the bounds of
   // the parent frame and let DWM handle compositing.  If not, then we don't
   // want to allow the bubble to extend the frame because it will be clipped.
   bubble_delegate->set_adjust_if_offscreen(ui::win::IsAeroGlassEnabled());
 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)
   // Linux clips bubble windows that extend outside their parent window bounds.
   bubble_delegate->set_adjust_if_offscreen(false);
@@ skipping 191 matching lines @@
   if (widget == GetWidget() && anchor_widget() &&
       anchor_widget()->GetTopLevelWidget()) {
     if (visible)
       anchor_widget()->GetTopLevelWidget()->DisableInactiveRendering();
     else
       anchor_widget()->GetTopLevelWidget()->EnableInactiveRendering();
   }
 }
 
 }  // namespace views