Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 962453002: Update permission bubble anchor when omnibar is hidden (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix issue Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index a85e479bd12b18442391c6724220b1c8e7c614dd..8930b372cc50fa3ea8ab525e8c874c59fb5ed2de 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -125,6 +125,11 @@ class BrowserView : public BrowserWindow,
// bubbles it creates will be associated with a single visible tab.
void InitPermissionBubbleView();
+ // Updates the permission bubble view. It's necessary to update the bubble
+ // view so that it is still relevant when the window transitions to/from
+ // fullscreen.
groby-ooo-7-16 2015/02/28 00:25:12 Technically, no. The bubble gets dismissed on a wi
hcarmona 2015/02/28 01:14:16 The permission bubble remains visible even on a wi
felt 2015/03/03 01:04:35 Good catch, I hadn't tested this. It should remai
hcarmona 2015/03/06 23:24:16 Where should we move the promt to? Centering the p
felt 2015/03/07 03:31:55 Is it possible to tell if the full screen prompt i
+ void UpdatePermissionBubbleView();
+
// Returns the apparent bounds of the toolbar, in BrowserView coordinates.
// These differ from |toolbar_.bounds()| in that they match where the toolbar
// background image is drawn -- slightly outside the "true" bounds
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698