Update permission bubble anchor when omnibar is hidden

chrome/browser/ui/views/frame/browser_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 107 matching lines @@
   // the bubble once and re-use it for the life of the browser, but certain
   // events (such as changing enabling/disabling Aero on Win) can force a need
   // to change some of the bubble's creation parameters.
   void InitStatusBubble();
 
   // Initializes the permission bubble view. This class is intended to be
   // created once and then re-used for the life of the browser window. The
   // bubbles it creates will be associated with a single visible tab.
   void InitPermissionBubbleView();
 
+  // Updates the permission bubble view. It's necessary to update the bubble
+  // view so that it is still relevant when the window transitions to/from
+  // fullscreen.

[groby-ooo-7-16, 2015/02/28 00:25:12]

Technically, no. The bubble gets dismissed on a window transition, no?

[hcarmona, 2015/02/28 01:14:16]

The permission bubble remains visible even on a window transition. This comment
is not clear enough that it will only update for the next time a new bubble is
shown.

Updated the comment, but you bring up a good point: should the permission
bubbles be dismissed?

[felt, 2015/03/03 01:04:35]

Good catch, I hadn't tested this.

It should remain visible, but moved into the center (like what your current CL
is doing otherwise if the omnibox is not visible).

The tricky thing here is that there also will be a full screen ephemeral prompt
in the same / nearby place, and it doesn't make sense to put them on top of each
other.

BTW you can test here: https://adrifelt.github.io/demos/all-permissions.html it
has both notifications (for prompt) and full screen mode.

[hcarmona, 2015/03/06 23:24:16]

Where should we move the promt to? Centering the prompt does make it look very
weird because it overlaps the full screen prompt.

[felt, 2015/03/07 03:31:55]

Is it possible to tell if the full screen prompt is also displayed, and if so,
push it down below it?

+  void UpdatePermissionBubbleView();
+
   // Returns the apparent bounds of the toolbar, in BrowserView coordinates.
   // These differ from |toolbar_.bounds()| in that they match where the toolbar
   // background image is drawn -- slightly outside the "true" bounds
   // horizontally. Note that this returns the bounds for the toolbar area.
   gfx::Rect GetToolbarBounds() const;
 
   // Returns the constraining bounding box that should be used to lay out the
   // FindBar within. This is _not_ the size of the find bar, just the bounding
   // box it should be laid out within. The coordinate system of the returned
   // rect is in the coordinate system of the frame, since the FindBar is a child
@@ skipping 560 matching lines @@
   scoped_ptr<ImmersiveModeController> immersive_mode_controller_;
 
   scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_;
 
   mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_