Add type for testing to interstitials.

content/public/browser/interstitial_page_delegate.h

Index: content/public/browser/interstitial_page_delegate.h
diff --git a/content/public/browser/interstitial_page_delegate.h b/content/public/browser/interstitial_page_delegate.h
index 74e4c4ccaade4d59d6251edf773680c7f5c6f420..d64879c25490ee51a769393d1959459554b303a4 100644
--- a/content/public/browser/interstitial_page_delegate.h
+++ b/content/public/browser/interstitial_page_delegate.h
@@ -16,8 +16,11 @@ struct RendererPreferences;
 
 // Controls and provides the html for an interstitial page. The delegate is
 // owned by the InterstitialPage.
-class InterstitialPageDelegate {
+class CONTENT_EXPORT InterstitialPageDelegate {
  public:
+  // An identifier used to identify an InterstitialPage.
+  typedef const void* TypeID;
+
   virtual ~InterstitialPageDelegate() {}
 
   // Return the HTML that should be displayed in the page.
@@ -42,6 +45,9 @@ class InterstitialPageDelegate {
   // Allows the delegate to override the renderer preferences structure that's
   // sent to the new RenderViewHost.
   virtual void OverrideRendererPrefs(content::RendererPreferences* prefs) {}
+
+  // Return the interstitial type for testing.
+  virtual TypeID GetTypeForTesting() const;

[Bernhard Bauer, 2015/03/03 09:56:00]

Do you really want to provide a default implementation instead of making it pure
virtual so that new interstitials are forced to add a type?

[meacer, 2015/03/03 18:33:05]

I started with a pure virtual method, but turns out we have a lot of tests that
create mock interstitials which would just return null. This seemed cleaner
since only the classes interested in testing the value need to implement it.

[Bernhard Bauer, 2015/03/03 21:40:51]

I'm more worried about the classes that are not testing it :) But fair enough.

 };
 
 }  // namespace content