Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3809)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 96233002: Add a PDF component extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/component_loader.cc
diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc
index 17f92789083c3b0cbb67e38731be7d6b2b225703..46ebd0d20e8aa0f8f45254f79163a2c7081cc6d4 100644
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -555,6 +555,13 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(
AddNetworkSpeechSynthesisExtension();
#endif
#endif // defined(GOOGLE_CHROME_BUILD)
+
+ base::FilePath pdf_path;
tapted 2013/12/02 04:17:19 does it need a #if defined(GOOGLE_CHROME_BUILD) gu
raymes 2013/12/04 04:54:49 This is the same check as in chrome_content_client
+ PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_path);
+ if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kOutOfProcessPdf) &&
+ base::PathExists(pdf_path)) {
tapted 2013/12/02 04:17:19 nit: I always indent these at 4 spaces. E.g. line
raymes 2013/12/04 04:54:49 Done.
+ Add(IDR_PDF_MANIFEST, base::FilePath(FILE_PATH_LITERAL("pdf")));
+ }
}
void ComponentLoader::UnloadComponent(ComponentExtensionInfo* component) {

Powered by Google App Engine
This is Rietveld 408576698