Add a PDF component extension

chrome/browser/extensions/component_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/component_loader.h"
 
 #include <map>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 537 matching lines @@
     Add(IDR_GOOGLE_NOW_MANIFEST,
         base::FilePath(FILE_PATH_LITERAL("google_now")));
   }
 #endif
 
 #if defined(GOOGLE_CHROME_BUILD)
 #if !defined(OS_CHROMEOS)  // http://crbug.com/314799
   AddNetworkSpeechSynthesisExtension();
 #endif
 #endif  // defined(GOOGLE_CHROME_BUILD)
+
+  base::FilePath pdf_path;

[tapted, 2013/12/02 04:17:19]

does it need a #if defined(GOOGLE_CHROME_BUILD) guard?

[raymes, 2013/12/04 04:54:49]

This is the same check as in chrome_content_client.cc. It allows the plugin to
work in Chromium as long as the dll is present.

+  PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_path);
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kOutOfProcessPdf) &&
+          base::PathExists(pdf_path)) {

[tapted, 2013/12/02 04:17:19]

nit: I always indent these at 4 spaces. E.g. line 511, 436

[raymes, 2013/12/04 04:54:49]

Done.

+    Add(IDR_PDF_MANIFEST, base::FilePath(FILE_PATH_LITERAL("pdf")));
+  }
 }
 
 void ComponentLoader::UnloadComponent(ComponentExtensionInfo* component) {
   delete component->manifest;
   if (extension_service_->is_ready()) {
     extension_service_->
         RemoveComponentExtension(component->extension_id);
   }
 }
 
 }  // namespace extensions