Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 962193002: Fix for 'Rotate clockwise/counter clockwise' should not present in context menu in crashed PDF page. (Closed)

Created:
5 years, 9 months ago by Deepak
Modified:
5 years, 9 months ago
Reviewers:
raymes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for 'Rotate clockwise/counter clockwise' should not present in context menu in crashed PDF page. When we are in the crashed PDf page then rotate does not have any use and it does nothing as only sad_plugin bitmap is painted. So rotate menu items should not present in the context menu. Changes done to check when plugin is crashed then rotation is not allowed. and rotate menu items are not added in context menu. BUG=462525 Committed: https://crrev.com/611754aea9d1c0ba5c7980fa267fd005dc249b85 Cr-Commit-Position: refs/heads/master@{#318647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
PTAL. Thanks
5 years, 9 months ago (2015-02-28 05:59:26 UTC) #2
raymes
lgtm
5 years, 9 months ago (2015-03-01 22:58:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962193002/1
5 years, 9 months ago (2015-03-02 02:47:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 04:21:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 04:22:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/611754aea9d1c0ba5c7980fa267fd005dc249b85
Cr-Commit-Position: refs/heads/master@{#318647}

Powered by Google App Engine
This is Rietveld 408576698