content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 962193002: Fix for 'Rotate clockwise/counter clockwise' should not present in context menu in crashed PDF page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 962193002: Fix for 'Rotate clockwise/counter clockwise' should not present in context menu in crashed PDF page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index fd5b495d10d637c0211d772f2cd5175a08e0940f..b4b75d3dded969128c5c886116f4f359913b7a82 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -1828,7 +1828,7 @@ bool PepperPluginInstanceImpl::GetPrintPresetOptionsFromDocument(

}

bool PepperPluginInstanceImpl::CanRotateView() {

- if (!LoadPdfInterface())

+ if (!LoadPdfInterface() || module()->is_crashed())

return false;

return true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »