Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 96203003: Switch HTMLCanvasElement over to new-style ExceptionState. (Closed)

Created:
7 years ago by sof
Modified:
7 years ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Switch HTMLCanvasElement over to new-style ExceptionState. Set up the calling context on toDataURL()'s incoming ExceptionState instead, for tidier generation of a possible SecurityError exception. To support throwing context-sensitive SecurityErrors, extend throwSecurityError() to also embellish its incoming messages. R= BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162887

Patch Set 1 #

Total comments: 2

Patch Set 2 : Capitalize the 'tainted' error messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -55 lines) Patch
M LayoutTests/http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/security/canvas-remote-read-remote-image-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt View 1 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/svg/as-image/svg-canvas-svg-with-image-with-link-tainted-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/as-image/svg-canvas-xhtml-tainted-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ExceptionState.h View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/bindings/v8/ExceptionState.cpp View 3 chunks +25 lines, -15 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
At your leisure, please take a look.
7 years ago (2013-11-29 06:41:08 UTC) #1
Mike West
LGTM, thanks for working on this! :) -mike https://codereview.chromium.org/96203003/diff/1/Source/core/html/HTMLCanvasElement.cpp File Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/96203003/diff/1/Source/core/html/HTMLCanvasElement.cpp#newcode376 Source/core/html/HTMLCanvasElement.cpp:376: exceptionState.throwSecurityError("tainted ...
7 years ago (2013-11-29 08:26:44 UTC) #2
sof
https://codereview.chromium.org/96203003/diff/1/Source/core/html/HTMLCanvasElement.cpp File Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/96203003/diff/1/Source/core/html/HTMLCanvasElement.cpp#newcode376 Source/core/html/HTMLCanvasElement.cpp:376: exceptionState.throwSecurityError("tainted canvases may not be exported."); On 2013/11/29 08:26:45, ...
7 years ago (2013-11-29 08:58:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/96203003/20001
7 years ago (2013-11-29 08:58:34 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-29 10:08:25 UTC) #5
Message was sent while issue was closed.
Change committed as 162887

Powered by Google App Engine
This is Rietveld 408576698