Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: Source/bindings/v8/ExceptionState.h

Issue 96203003: Switch HTMLCanvasElement over to new-style ExceptionState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Capitalize the 'tainted' error messages Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ExceptionState.h
diff --git a/Source/bindings/v8/ExceptionState.h b/Source/bindings/v8/ExceptionState.h
index a58784fdfc13aa864f1fd9bc26e503f7eb3e2fce..bfe2790e16a84ac1aa19d47d039b94074bdf9fe8 100644
--- a/Source/bindings/v8/ExceptionState.h
+++ b/Source/bindings/v8/ExceptionState.h
@@ -88,7 +88,7 @@ public:
bool hadException() const { return !m_exception.isEmpty() || m_code; }
void clearException();
- ExceptionCode code() { return m_code; }
+ ExceptionCode code() const { return m_code; }
bool throwIfNeeded()
{
@@ -102,9 +102,9 @@ public:
return true;
}
- Context context() { return m_context; }
- const char* propertyName() { return m_propertyName; }
- const char* interfaceName() { return m_interfaceName; }
+ Context context() const { return m_context; }
+ const char* propertyName() const { return m_propertyName; }
+ const char* interfaceName() const { return m_interfaceName; }
protected:
ExceptionCode m_code;
@@ -115,6 +115,8 @@ protected:
private:
void setException(v8::Handle<v8::Value>);
+ String addExceptionContext(const String&) const;
+
ScopedPersistent<v8::Value> m_exception;
v8::Handle<v8::Object> m_creationContext;
v8::Isolate* m_isolate;
« no previous file with comments | « LayoutTests/svg/as-image/svg-canvas-xhtml-tainted-expected.txt ('k') | Source/bindings/v8/ExceptionState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698