Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 962013002: Left align bubble title and text, adjusted spacing between. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/bubble_frame_view.cc
diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc
index 599d5965f2880ab57ca9218144a0cf0877aa48cd..7d34504e545239920013621e6f81ee0488682424 100644
--- a/ui/views/bubble/bubble_frame_view.cc
+++ b/ui/views/bubble/bubble_frame_view.cc
@@ -23,9 +23,9 @@
namespace {
// Insets for the title bar views in pixels.
-const int kTitleTopInset = 12;
-const int kTitleLeftInset = 19;
-const int kTitleBottomInset = 12;
+const int kTitleTopInset = 18;
msw 2015/02/27 01:57:05 Don't change this value... the title wasn't too hi
xiaoling 2015/02/27 02:24:13 Was trying to make top margin to 20 px. Reverted.
+const int kTitleLeftInset = 20;
msw 2015/02/27 01:57:05 Don't bother changing this, just add 1px in the ic
xiaoling 2015/02/27 02:24:13 Done.
+const int kTitleBottomInset = 7;
msw 2015/02/27 01:57:05 This can't be right, it will affect all bubbles...
xiaoling 2015/02/27 02:24:13 Done.
const int kTitleRightInset = 7;
// The horizontal padding between the title and the icon.

Powered by Google App Engine
This is Rietveld 408576698