Left align bubble title and text, adjusted spacing between.

ui/views/bubble/bubble_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/bubble/bubble_frame_view.h"
 
 #include <algorithm>
 
 #include "ui/base/hit_test.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/path.h"
 #include "ui/gfx/screen.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/bubble/bubble_border.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/views/window/client_view.h"
 
 namespace {
 
 // Insets for the title bar views in pixels.
-const int kTitleTopInset = 12;
-const int kTitleLeftInset = 19;
-const int kTitleBottomInset = 12;
+const int kTitleTopInset = 18;

[msw, 2015/02/27 01:57:05]

Don't change this value... the title wasn't too high. If anything, we may need
to move the icon down to match the cap-height centering of the title text, but
you can consider addressing that in a separate CL.

[xiaoling, 2015/02/27 02:24:13]

Was trying to make top margin to 20 px. Reverted.

+const int kTitleLeftInset = 20;

[msw, 2015/02/27 01:57:05]

Don't bother changing this, just add 1px in the icon case, if anything.

[xiaoling, 2015/02/27 02:24:13]

Done.

+const int kTitleBottomInset = 7;

[msw, 2015/02/27 01:57:05]

This can't be right, it will affect all bubbles... The global error bubble
itself must be using incorrect content margins or something else that adds
unintended padding; see my comment with the bubble, it should replace it's
default 6px top margin and tweak other margins as needed.

[xiaoling, 2015/02/27 02:24:13]

Done.

 const int kTitleRightInset = 7;
 
 // The horizontal padding between the title and the icon.
 const int kTitleHorizontalPadding = 5;
 
 // Get the |vertical| or horizontal amount that |available_bounds| overflows
 // |window_bounds|.
 int GetOffScreenLength(const gfx::Rect& available_bounds,
                        const gfx::Rect& window_bounds,
                        bool vertical) {
@@ skipping 382 matching lines @@
   if (titlebar_extra_view_ != NULL)
     title_bar_width += titlebar_extra_view_->GetPreferredSize().width();
   gfx::Size size(client_size);
   size.SetToMax(gfx::Size(title_bar_width, 0));
   const gfx::Insets insets(GetInsets());
   size.Enlarge(insets.width(), insets.height());
   return size;
 }
 
 }  // namespace views