Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.cc

Issue 962013002: Left align bubble title and text, adjusted spacing between. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/bubble/bubble_frame_view.cc » ('j') | ui/views/bubble/bubble_frame_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/global_error_bubble_view.cc
diff --git a/chrome/browser/ui/views/global_error_bubble_view.cc b/chrome/browser/ui/views/global_error_bubble_view.cc
index 1fae5f6ecac3155877a94062b443328ea69685e0..b316556e21d0b24d750716f9b0cd6a37d0d2f854 100644
--- a/chrome/browser/ui/views/global_error_bubble_view.cc
+++ b/chrome/browser/ui/views/global_error_bubble_view.cc
@@ -35,6 +35,9 @@ const int kMaxBubbleViewWidth = 262;
// The vertical inset of the wrench bubble anchor from the wrench menu button.
const int kAnchorVerticalInset = 5;
+// Align bubble text with the title.
+const int kBubbleLeftPadding = 14;
+
const int kBubblePadding = 6;
} // namespace
@@ -106,7 +109,7 @@ GlobalErrorBubbleView::GlobalErrorBubbleView(
SetLayoutManager(layout);
// BubbleFrameView adds enough padding below title, no top padding needed.
- layout->SetInsets(0, kBubblePadding, kBubblePadding, kBubblePadding);
+ layout->SetInsets(0, kBubbleLeftPadding, kBubblePadding, kBubblePadding);
msw 2015/02/27 01:57:05 You should probably leave the layout's insets empt
xiaoling 2015/02/27 02:24:12 Done.
// First row, message labels.
views::ColumnSet* cs = layout->AddColumnSet(0);
« no previous file with comments | « no previous file | ui/views/bubble/bubble_frame_view.cc » ('j') | ui/views/bubble/bubble_frame_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698