Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 962003002: gn format: Have format sort sources (Closed)

Created:
5 years, 9 months ago by scottmg
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn format: Have format sort sources Sorts sources blocks as part of gn format. This ended up being more complicated than I expected because of the subtlety of header comments, and because no other formatting reorders expressions at the moment. But, there seems to be quite a lot of unsorted lists per below, so I guess it's a good thing to have. Application to tree at https://codereview.chromium.org/960413003. R=brettw@chromium.org BUG=348474, 456014 Committed: https://crrev.com/5786a631ae64e933a24a62bf7a2d579fd4a36834 Cr-Commit-Position: refs/heads/master@{#318580}

Patch Set 1 #

Patch Set 2 : accessors in list #

Patch Set 3 : more complicated separator handling #

Patch Set 4 : more better headers #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 14

Patch Set 7 : better #

Patch Set 8 : unsigned numbers in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -16 lines) Patch
M tools/gn/command_format.cc View 1 2 3 4 5 6 4 chunks +25 lines, -6 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/format_test_data/031.golden View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/format_test_data/062.gn View 1 2 3 1 chunk +112 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/062.golden View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download
M tools/gn/parse_tree.h View 1 2 3 4 5 6 6 chunks +20 lines, -9 lines 0 comments Download
M tools/gn/parse_tree.cc View 1 2 3 4 5 6 6 chunks +149 lines, -1 line 0 comments Download
M tools/gn/parse_tree_unittest.cc View 1 2 3 4 5 6 7 1 chunk +103 lines, -0 lines 0 comments Download
M tools/gn/token.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
scottmg
5 years, 9 months ago (2015-02-27 03:12:06 UTC) #1
brettw
https://codereview.chromium.org/962003002/diff/100001/tools/gn/command_format.cc File tools/gn/command_format.cc (right): https://codereview.chromium.org/962003002/diff/100001/tools/gn/command_format.cc#newcode319 tools/gn/command_format.cc:319: if (lhs == "sources") { No {} to match ...
5 years, 9 months ago (2015-02-27 22:27:27 UTC) #2
scottmg
https://codereview.chromium.org/962003002/diff/100001/tools/gn/command_format.cc File tools/gn/command_format.cc (right): https://codereview.chromium.org/962003002/diff/100001/tools/gn/command_format.cc#newcode319 tools/gn/command_format.cc:319: if (lhs == "sources") { On 2015/02/27 22:27:26, brettw ...
5 years, 9 months ago (2015-02-27 23:17:44 UTC) #3
brettw
lgtm
5 years, 9 months ago (2015-02-28 00:34:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962003002/120001
5 years, 9 months ago (2015-02-28 00:42:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962003002/140001
5 years, 9 months ago (2015-02-28 01:35:11 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 9 months ago (2015-02-28 02:47:38 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 02:48:15 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/5786a631ae64e933a24a62bf7a2d579fd4a36834
Cr-Commit-Position: refs/heads/master@{#318580}

Powered by Google App Engine
This is Rietveld 408576698