Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 960413003: Apply gn format with 'sources' sorting to src/ (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 9 months ago
Reviewers:
keybuk, brettw, eseidel
CC:
Aaron Boodman, abarth-chromium, aboxhall+watch_chromium.org, albertb+watch_chromium.org, ben+mojo_chromium.org, caitkp+watch_chromium.org, cbentzel+watch_chromium.org, cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dmazzoni+watch_chromium.org, Dai Mikurube (NOT FULLTIME), dtseng+watch_chromium.org, eme-reviews_chromium.org, erikwright+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, jdduke+watch_chromium.org, je_julie(Not used), jln+watch_chromium.org, jochen+watch_chromium.org, jshin+watch_chromium.org, kalyank, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, nona+watch_chromium.org, ozone-reviews_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, plundblad+watch_chromium.org, pvalenzuela+watch_chromium.org, qsr+mojo_chromium.org, rickyz+watch_chromium.org, sadrul, sievers+watch_chromium.org, James Su, tdresser+watch_chromium.org, tfarina, tim+watch_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org, yuzo+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-format-sort-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply gn format with 'sources' sorting to src/ Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Committed: https://crrev.com/7c7296f4dcb7e32fa4440b333a40a37699f517b1 Cr-Commit-Position: refs/heads/master@{#318574}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -427 lines) Patch
M base/BUILD.gn View 1 2 chunks +6 lines, -6 lines 1 comment Download
M base/third_party/nspr/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M breakpad/BUILD.gn View 7 chunks +17 lines, -17 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M build/secondary/third_party/cacheinvalidation/BUILD.gn View 4 chunks +8 lines, -8 lines 0 comments Download
M build/secondary/third_party/leveldatabase/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M build/secondary/third_party/libsrtp/BUILD.gn View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 4 chunks +8 lines, -8 lines 0 comments Download
M build/secondary/third_party/sfntly/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/BUILD.gn View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/android/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/audio_modem/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/constrained_window/BUILD.gn View 1 chunk +1 line, -1 line 2 comments Download
M components/nacl/BUILD.gn View 5 chunks +15 lines, -15 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M courgette/BUILD.gn View 4 chunks +13 lines, -13 lines 0 comments Download
M crypto/BUILD.gn View 4 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M device/core/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M extensions/common/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M gin/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M pdf/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M printing/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/BUILD.gn View 6 chunks +21 lines, -21 lines 0 comments Download
M sdch/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 1 2 9 chunks +12 lines, -11 lines 0 comments Download
M storage/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M storage/common/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M sync/protocol/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/android_protobuf/BUILD.gn View 4 chunks +24 lines, -24 lines 0 comments Download
M third_party/ashmem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld/BUILD.gn View 4 chunks +24 lines, -24 lines 0 comments Download
M third_party/cld_2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/elfutils/BUILD.gn View 5 chunks +12 lines, -12 lines 0 comments Download
M third_party/fontconfig/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +24 lines, -24 lines 0 comments Download
M third_party/iaccessible2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libexif/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libxml/BUILD.gn View 5 chunks +24 lines, -24 lines 0 comments Download
M third_party/libxslt/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/lzma_sdk/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mesa/BUILD.gn View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/js/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/application/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/BUILD.gn View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/environment/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/utility/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/mojo/src/mojo/public/platform/native/BUILD.gn View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/mojo_services/src/input_events/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/native_viewport/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/ots/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 2 5 chunks +35 lines, -33 lines 0 comments Download
M third_party/speex/BUILD.gn View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.gni View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/BUILD.gn View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/imagediff/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/test/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/relocation_packer/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
scottmg
https://codereview.chromium.org/960413003/diff/80001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/960413003/diff/80001/base/BUILD.gn#newcode389 base/BUILD.gn:389: "metrics/histogram_delta_serialization.", hmm, will fix that in a separate cl.
5 years, 10 months ago (2015-02-27 03:13:50 UTC) #3
brettw
lgtm https://codereview.chromium.org/960413003/diff/80001/components/constrained_window/BUILD.gn File components/constrained_window/BUILD.gn (right): https://codereview.chromium.org/960413003/diff/80001/components/constrained_window/BUILD.gn#newcode14 components/constrained_window/BUILD.gn:14: "//ui/views", Will deps sorting be done later?
5 years, 9 months ago (2015-02-27 21:02:28 UTC) #4
scottmg
https://codereview.chromium.org/960413003/diff/80001/components/constrained_window/BUILD.gn File components/constrained_window/BUILD.gn (right): https://codereview.chromium.org/960413003/diff/80001/components/constrained_window/BUILD.gn#newcode14 components/constrained_window/BUILD.gn:14: "//ui/views", On 2015/02/27 21:02:28, brettw wrote: > Will deps ...
5 years, 9 months ago (2015-02-27 21:04:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960413003/80001
5 years, 9 months ago (2015-02-28 00:44:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/46317)
5 years, 9 months ago (2015-02-28 02:00:44 UTC) #9
scottmg
tbr keybuk for device/bluetooth
5 years, 9 months ago (2015-02-28 02:05:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960413003/80001
5 years, 9 months ago (2015-02-28 02:06:35 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 9 months ago (2015-02-28 02:23:21 UTC) #14
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/7c7296f4dcb7e32fa4440b333a40a37699f517b1 Cr-Commit-Position: refs/heads/master@{#318574}
5 years, 9 months ago (2015-02-28 02:24:19 UTC) #15
eseidel
5 years, 9 months ago (2015-02-28 16:00:42 UTC) #17
Message was sent while issue was closed. 
This is amazing, thank you!

Powered by Google App Engine
This is Rietveld 408576698