Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 961973002: [turbofan] First shot at eager deoptimization in Turbofan. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
CC:
Michael Starzinger, titzer, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] First shot at eager deoptimization in Turbofan. BUG= Committed: https://crrev.com/8d2e45669f84076e95131503ea623f32483b3a7d Cr-Commit-Position: refs/heads/master@{#26993}

Patch Set 1 #

Patch Set 2 : Simple test #

Total comments: 2

Patch Set 3 : Addressed a review comment #

Patch Set 4 : Fix #

Patch Set 5 : Fix 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -35 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +32 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 2 chunks +42 lines, -1 line 2 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/node-properties.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/node-properties.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/schedule.h View 2 chunks +12 lines, -7 lines 0 comments Download
M src/compiler/schedule.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/eager-deopt-simple.js View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-02-27 08:05:10 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/961973002/diff/20001/src/compiler/js-intrinsic-lowering.cc File src/compiler/js-intrinsic-lowering.cc (right): https://codereview.chromium.org/961973002/diff/20001/src/compiler/js-intrinsic-lowering.cc#newcode63 src/compiler/js-intrinsic-lowering.cc:63: NodeProperties::ReplaceWithValue(node, jsgraph()->UndefinedConstant(), Please add control parameter to ReplaceWithValue() instead ...
5 years, 9 months ago (2015-02-27 08:27:14 UTC) #3
Jarin
https://codereview.chromium.org/961973002/diff/20001/src/compiler/js-intrinsic-lowering.cc File src/compiler/js-intrinsic-lowering.cc (right): https://codereview.chromium.org/961973002/diff/20001/src/compiler/js-intrinsic-lowering.cc#newcode63 src/compiler/js-intrinsic-lowering.cc:63: NodeProperties::ReplaceWithValue(node, jsgraph()->UndefinedConstant(), On 2015/02/27 08:27:14, Benedikt Meurer wrote: > ...
5 years, 9 months ago (2015-02-27 09:14:40 UTC) #4
Jarin
On 2015/02/27 09:14:40, jarin wrote: > https://codereview.chromium.org/961973002/diff/20001/src/compiler/js-intrinsic-lowering.cc > File src/compiler/js-intrinsic-lowering.cc (right): > > https://codereview.chromium.org/961973002/diff/20001/src/compiler/js-intrinsic-lowering.cc#newcode63 > ...
5 years, 9 months ago (2015-03-03 12:00:37 UTC) #5
Benedikt Meurer
LGTM
5 years, 9 months ago (2015-03-04 05:20:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961973002/80001
5 years, 9 months ago (2015-03-04 14:58:17 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-04 15:21:19 UTC) #9
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/8d2e45669f84076e95131503ea623f32483b3a7d Cr-Commit-Position: refs/heads/master@{#26993}
5 years, 9 months ago (2015-03-04 15:21:29 UTC) #10
Michael Starzinger
Follow-up comment. https://codereview.chromium.org/961973002/diff/80001/src/compiler/js-intrinsic-lowering.cc File src/compiler/js-intrinsic-lowering.cc (right): https://codereview.chromium.org/961973002/diff/80001/src/compiler/js-intrinsic-lowering.cc#newcode24 src/compiler/js-intrinsic-lowering.cc:24: case Runtime::kDeoptimizeNow: Would it be possible to ...
5 years, 9 months ago (2015-03-04 23:36:42 UTC) #12
Jarin
5 years, 9 months ago (2015-03-05 06:32:16 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/961973002/diff/80001/src/compiler/js-intrinsi...
File src/compiler/js-intrinsic-lowering.cc (right):

https://codereview.chromium.org/961973002/diff/80001/src/compiler/js-intrinsi...
src/compiler/js-intrinsic-lowering.cc:24: case Runtime::kDeoptimizeNow:
On 2015/03/04 23:36:42, Michael Starzinger wrote:
> Would it be possible to move the function to INLINE_OPTIMIZED_FUNCTION_LIST,
> thereby %DeoptimizeNow would become %_DeoptimizeNow (a syntax hit that is IMHO
> acceptable), but restore the invariant that only the "inline intrisics" are
> actually inlined?

It would be possible, but we would also have to implement a Crankshaft version.
I did not want to touch Crankshaft.

Powered by Google App Engine
This is Rietveld 408576698