Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 961843002: Add F13 - F24 for evdev/xkb to scan code table. (Closed)

Created:
5 years, 10 months ago by kpschoedel
Modified:
5 years, 10 months ago
Reviewers:
Wez, spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Add F13 - F24 for evdev/xkb to scan code table. F13 - F15 in particular are needed for lock, key help, and diamond keys on extended ChromeOS keyboards. BUG=454865 Review URL: https://codereview.chromium.org/934003002 Cr-Commit-Position: refs/heads/master@{#317902} (cherry picked from commit 5ee26afb9b37dcc594dfb42ffd98a08d63b7631e) TBR=Wez,spang Committed: https://chromium.googlesource.com/chromium/src/+/b0e4b97d2aed98e3d434416bfdee2ac4054405d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M ui/events/keycodes/dom4/keycode_converter_data.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ui/events/keycodes/dom4/keycode_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kpschoedel
5 years, 10 months ago (2015-02-26 17:14:24 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0e4b97d2aed98e3d434416bfdee2ac4054405d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698