Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 934003002: Add F13 - F24 for evdev/xkb to scan code table. (Closed)

Created:
5 years, 10 months ago by kpschoedel
Modified:
5 years, 10 months ago
Reviewers:
Wez, spang
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add F13 - F24 for evdev/xkb to scan code table. F13 - F15 in particular are needed for lock, key help, and diamond keys on extended ChromeOS keyboards. BUG=454865 Committed: https://crrev.com/5ee26afb9b37dcc594dfb42ffd98a08d63b7631e Cr-Commit-Position: refs/heads/master@{#317902}

Patch Set 1 #

Patch Set 2 : Recognize XKB 'inet' function key mappings #

Total comments: 2

Patch Set 3 : Update mapped key count in unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M ui/events/keycodes/dom4/keycode_converter_data.h View 1 chunk +13 lines, -13 lines 0 comments Download
M ui/events/keycodes/dom4/keycode_converter_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
kpschoedel
5 years, 10 months ago (2015-02-17 17:15:03 UTC) #2
kpschoedel
+spang for ozone/layout
5 years, 10 months ago (2015-02-17 18:20:08 UTC) #4
spang
lgtm
5 years, 10 months ago (2015-02-17 18:56:56 UTC) #5
Wez
https://codereview.chromium.org/934003002/diff/20001/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc File ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc (right): https://codereview.chromium.org/934003002/diff/20001/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc#newcode155 ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc:155: case XKB_KEY_XF86Tools: // XKB 'inet' mapping of F13 Didn't ...
5 years, 10 months ago (2015-02-21 00:09:38 UTC) #6
kpschoedel
https://codereview.chromium.org/934003002/diff/20001/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc File ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc (right): https://codereview.chromium.org/934003002/diff/20001/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc#newcode155 ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc:155: case XKB_KEY_XF86Tools: // XKB 'inet' mapping of F13 On ...
5 years, 10 months ago (2015-02-23 16:26:11 UTC) #7
Wez
lgtm
5 years, 10 months ago (2015-02-23 19:02:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934003002/20001
5 years, 10 months ago (2015-02-23 19:21:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61839)
5 years, 10 months ago (2015-02-23 19:24:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934003002/20001
5 years, 10 months ago (2015-02-24 19:53:31 UTC) #14
kpschoedel
5 years, 10 months ago (2015-02-24 19:57:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934003002/40001
5 years, 10 months ago (2015-02-24 19:57:48 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-24 22:34:17 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 22:35:19 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ee26afb9b37dcc594dfb42ffd98a08d63b7631e
Cr-Commit-Position: refs/heads/master@{#317902}

Powered by Google App Engine
This is Rietveld 408576698