src/ic/ia32/handler-compiler-ia32.cc - Issue 961723002: Also skip when the target is the global object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ia32/handler-compiler-ia32.cc

Issue 961723002: Also skip when the target is the global object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ia32/handler-compiler-ia32.cc

diff --git a/src/ic/ia32/handler-compiler-ia32.cc b/src/ic/ia32/handler-compiler-ia32.cc

index 7bb426c61e559d847f11707a6d5439a04f04193c..850bfbd3ea0b08838bec69274ce2773e887c2c49 100644

--- a/src/ic/ia32/handler-compiler-ia32.cc

+++ b/src/ic/ia32/handler-compiler-ia32.cc

@@ -498,7 +498,8 @@ Register PropertyHandlerCompiler::CheckPrototypes(

// Log the check depth.

LOG(isolate(), IntEvent("check-maps-depth", depth + 1));

- if (depth != 0 || check == CHECK_ALL_MAPS) {

+ if (!current_map->IsJSGlobalObjectMap() &&

+ (depth != 0 || check == CHECK_ALL_MAPS)) {

// Check the holder map.

__ mov(scratch1, FieldOperand(reg, HeapObject::kMapOffset));

Handle<WeakCell> cell = Map::WeakCellForMap(current_map);

« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »