Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 961723002: Also skip when the target is the global object (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Also skip when the target is the global object BUG= Committed: https://crrev.com/cc918d30b9d586ce974b71232473f2ae3c5e7847 Cr-Commit-Position: refs/heads/master@{#26887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-26 14:54:03 UTC) #2
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-26 15:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961723002/1
5 years, 10 months ago (2015-02-26 15:10:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 15:29:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc918d30b9d586ce974b71232473f2ae3c5e7847 Cr-Commit-Position: refs/heads/master@{#26887}
5 years, 10 months ago (2015-02-26 15:29:24 UTC) #7
Michael Achenbach
5 years, 10 months ago (2015-02-26 21:03:10 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/960363002/ by machenbach@chromium.org.

The reason for reverting is: Breaks unscopables and fix attempt needed to be
reverted too..

Powered by Google App Engine
This is Rietveld 408576698