Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 961693004: Rearrange the Document interfaces to match the many specs (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rearrange the Document interfaces to match the many specs https://dom.spec.whatwg.org/#interface-document https://html.spec.whatwg.org/#the-document-object and many other specs with partial Document interfaces. To make reviewing easier, this commit only changes the order of lines and adds comments. Actual spec sync will be done separate. The order of the generated code changes, but there are no actual changes. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -121 lines) Patch
M Source/core/dom/Document.idl View 4 chunks +95 lines, -105 lines 0 comments Download
M Source/core/dom/XMLDocument.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +21 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL. Part 2 in https://codereview.chromium.org/960923005
5 years, 10 months ago (2015-02-27 04:07:29 UTC) #2
haraken
LGTM, thanks for splitting!
5 years, 10 months ago (2015-02-27 07:45:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961693004/1
5 years, 10 months ago (2015-02-27 07:59:28 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-27 08:02:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190981

Powered by Google App Engine
This is Rietveld 408576698