|
|
Created:
5 years, 10 months ago by philipj_slow Modified:
5 years, 9 months ago Reviewers:
haraken, Jens Widell CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionSync the Document interfaces with the many specs
https://dom.spec.whatwg.org/#interface-document
https://html.spec.whatwg.org/#the-document-object
and many other specs with partial Document interfaces.
createAttributeNS's second argument was not renamed:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=28109
createEvent's interface argument and many arguments named namespace were
also not renamed, as those are C++ keywords.
The only changes to the generated code are due to renamed arguments.
BUG=460722
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190984
Patch Set 1 #
Total comments: 4
Created: 5 years, 10 months ago
Messages
Total messages: 13 (5 generated)
philipj@opera.com changed reviewers: + haraken@chromium.org
PTAL. Depends on https://codereview.chromium.org/961693004/
haraken@chromium.org changed reviewers: + jl@opera.com
LGTM. https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl... Source/core/dom/Document.idl:94: // FIXME: domain should not have [TreatNullAs=NullString]. Jens: I'm sorry for asking similar questions repeatedly, but what's a difference between [TreatNullAs=NullString] and DOMString? ? https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl... Source/core/dom/Document.idl:156: sequence<Element> elementsFromPoint(long x, long y); Jens: There is no difference between [] and a sequence, and the new spec is expected to use a sequence instead of [], right?
https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl... Source/core/dom/Document.idl:94: // FIXME: domain should not have [TreatNullAs=NullString]. On 2015/02/27 07:54:12, haraken wrote: > > Jens: I'm sorry for asking similar questions repeatedly, but what's a difference > between [TreatNullAs=NullString] and DOMString? ? For an attribute, the difference is what happens if the C++ getter (i.e. impl->domain()) returns a null string: with [TreatNullAs=NullString] (which doesn't affect this situation) an empty string will be returned (v8SetReturnValueString() is used), whereas with DOMString? null is returned (v8SetReturnValueStringOrNull() is used). For an attribute setter and for a method argument, [TreatNullAs=NullString] and DOMString? lead to identical generated code. https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl... Source/core/dom/Document.idl:156: sequence<Element> elementsFromPoint(long x, long y); On 2015/02/27 07:54:12, haraken wrote: > > Jens: There is no difference between [] and a sequence, and the new spec is > expected to use a sequence instead of [], right? There's no difference in our code generation, as far as I know. The difference according to WebIDL is that sequence<T> is passed by value whereas T[] is passed by reference, but in practice, we pass both by value (since we always translate between V8 object and Vector<T> in the bindings layer).
On 2015/02/27 08:09:42, Jens Widell wrote: > https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl > File Source/core/dom/Document.idl (right): > > https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl... > Source/core/dom/Document.idl:94: // FIXME: domain should not have > [TreatNullAs=NullString]. > On 2015/02/27 07:54:12, haraken wrote: > > > > Jens: I'm sorry for asking similar questions repeatedly, but what's a > difference > > between [TreatNullAs=NullString] and DOMString? ? > > For an attribute, the difference is what happens if the C++ getter (i.e. > impl->domain()) returns a null string: with [TreatNullAs=NullString] (which > doesn't affect this situation) an empty string will be returned > (v8SetReturnValueString() is used), whereas with DOMString? null is returned > (v8SetReturnValueStringOrNull() is used). > > For an attribute setter and for a method argument, [TreatNullAs=NullString] and > DOMString? lead to identical generated code. > > https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl... > Source/core/dom/Document.idl:156: sequence<Element> elementsFromPoint(long x, > long y); > On 2015/02/27 07:54:12, haraken wrote: > > > > Jens: There is no difference between [] and a sequence, and the new spec is > > expected to use a sequence instead of [], right? > > There's no difference in our code generation, as far as I know. The difference > according to WebIDL is that sequence<T> is passed by value whereas T[] is passed > by reference, but in practice, we pass both by value (since we always translate > between V8 object and Vector<T> in the bindings layer). Makes sense; thanks for the clarification!
The CQ bit was checked by philipj@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960923005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/4...)
The CQ bit was checked by philipj@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960923005/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190984 |