Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 960923005: Sync the Document interfaces with the many specs (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the Document interfaces with the many specs https://dom.spec.whatwg.org/#interface-document https://html.spec.whatwg.org/#the-document-object and many other specs with partial Document interfaces. createAttributeNS's second argument was not renamed: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28109 createEvent's interface argument and many arguments named namespace were also not renamed, as those are C++ keywords. The only changes to the generated code are due to renamed arguments. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190984

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -36 lines) Patch
M Source/core/dom/Document.idl View 6 chunks +58 lines, -36 lines 4 comments Download

Messages

Total messages: 13 (5 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/961693004/
5 years, 10 months ago (2015-02-27 04:07:59 UTC) #2
haraken
LGTM. https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl#newcode94 Source/core/dom/Document.idl:94: // FIXME: domain should not have [TreatNullAs=NullString]. Jens: ...
5 years, 9 months ago (2015-02-27 07:54:12 UTC) #4
Jens Widell
https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl File Source/core/dom/Document.idl (right): https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl#newcode94 Source/core/dom/Document.idl:94: // FIXME: domain should not have [TreatNullAs=NullString]. On 2015/02/27 ...
5 years, 9 months ago (2015-02-27 08:09:42 UTC) #5
haraken
On 2015/02/27 08:09:42, Jens Widell wrote: > https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl > File Source/core/dom/Document.idl (right): > > https://codereview.chromium.org/960923005/diff/1/Source/core/dom/Document.idl#newcode94 ...
5 years, 9 months ago (2015-02-27 08:16:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960923005/1
5 years, 9 months ago (2015-02-27 08:17:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/49242)
5 years, 9 months ago (2015-02-27 09:39:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960923005/1
5 years, 9 months ago (2015-02-27 09:47:07 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 11:33:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190984

Powered by Google App Engine
This is Rietveld 408576698