Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 961693002: Skip the mapcheck on the global object since the global proxy and cell are already checked (or the … (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip the mapcheck on the global object since the global proxy and cell are already checked (or the global object map for contextual global loads). BUG= Committed: https://crrev.com/6af7ca6be4cd768b3326f0b8c32d4fbc3baa20c8 Cr-Commit-Position: refs/heads/master@{#26886}

Patch Set 1 #

Patch Set 2 : Add DCHECK everywhere #

Patch Set 3 : Merge branches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-26 14:34:06 UTC) #2
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-26 14:42:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961693002/40001
5 years, 10 months ago (2015-02-26 14:45:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 15:12:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 15:12:17 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6af7ca6be4cd768b3326f0b8c32d4fbc3baa20c8
Cr-Commit-Position: refs/heads/master@{#26886}

Powered by Google App Engine
This is Rietveld 408576698