Enable right clicking on the applist doodle web contents and log the data.

Enable right clicking on the applist doodle web contents and log the data.

This CL enables the context menu on the doodle web contents and logs
the received doodle data. This will be reverted in a future patch
once an issue with the doodle not displaying is diagnosed.

BUG=462082
Committed: https://crrev.com/04ed07f25bb0dca9e5c309e6ecdd69736520db68
Cr-Commit-Position: refs/heads/master@{#318198}

[calamity, 2015-02-26 03:04:00]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-02-26 03:07:08]

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
File chrome/browser/resources/app_list/start_page.js (right):

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
chrome/browser/resources/app_list/start_page.js:87: this.doodleData =
data.ddljson;
You aren't using this any more? (Since you seem to be VLOGging it from C++
rather than console.logging it from JS.)

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
chrome/browser/resources/app_list/start_page.js:157:
document.addEventListener('DOMContentLoaded', appList.startPage.initialize);
// TODO(calamity): Uncomment this line to suppress the context menu, after
http://crbug.com/462082 is diagnosed.
// document.addEventListener('contextmenu', function(e) { e.preventDefault();
});

https://codereview.chromium.org/961553002/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/start_page_service.cc (right):

https://codereview.chromium.org/961553002/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/start_page_service.cc:633: VLOG(1) << "App list
doodle data = " << json_data;
// TODO(calamity): Remove this log after http://crbug.com/462082 is diagnosed.

[Matt Giuca, 2015-02-26 03:09:28]

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
File chrome/browser/resources/app_list/start_page.js (right):

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
chrome/browser/resources/app_list/start_page.js:87: this.doodleData =
data.ddljson;
OK, then 1. Add a TODO explaining that this is for manual inspection and to be
removed later, and 2. Move this line down below var doodleData, and then just
write:

this.doodleData = doodleData;

[calamity, 2015-02-26 03:27:20]

Patchset #2 (id:20001) has been deleted

[calamity, 2015-02-26 03:27:26]

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
File chrome/browser/resources/app_list/start_page.js (right):

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
chrome/browser/resources/app_list/start_page.js:87: this.doodleData =
data.ddljson;
On 2015/02/26 03:07:08, Matt Giuca wrote:
> You aren't using this any more? (Since you seem to be VLOGging it from C++
> rather than console.logging it from JS.)

Keeping it here for inspection purposes.

https://codereview.chromium.org/961553002/diff/1/chrome/browser/resources/app...
chrome/browser/resources/app_list/start_page.js:157:
document.addEventListener('DOMContentLoaded', appList.startPage.initialize);
On 2015/02/26 03:07:08, Matt Giuca wrote:
> // TODO(calamity): Uncomment this line to suppress the context menu, after
> http://crbug.com/462082 is diagnosed.
> // document.addEventListener('contextmenu', function(e) { e.preventDefault();
> });

Did what was discussed.

https://codereview.chromium.org/961553002/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/start_page_service.cc (right):

https://codereview.chromium.org/961553002/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/start_page_service.cc:633: VLOG(1) << "App list
doodle data = " << json_data;
On 2015/02/26 03:07:08, Matt Giuca wrote:
> // TODO(calamity): Remove this log after http://crbug.com/462082 is diagnosed.

Changed to a warning log of crashed renderer instead as discussed.

[Matt Giuca, 2015-02-26 04:19:51]

No uploadeys?

[calamity, 2015-02-26 04:33:29]

Patchset #2 (id:40001) has been deleted

[Matt Giuca, 2015-02-26 04:34:55]

lgtm

https://codereview.chromium.org/961553002/diff/60001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/start_page_service.cc (right):

https://codereview.chromium.org/961553002/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/start_page_service.cc:570: // TODO(calamity): Remove
this log after http://crbug.com/462082 is diagnosed.
I think this can be left in permanently (so drop this TODO). Unless you really
think it shouldn't be there.

[calamity, 2015-02-26 05:12:14]

On 2015/02/26 04:34:55, Matt Giuca wrote:
> lgtm
> 
>
https://codereview.chromium.org/961553002/diff/60001/chrome/browser/ui/app_li...
> File chrome/browser/ui/app_list/start_page_service.cc (right):
> 
>
https://codereview.chromium.org/961553002/diff/60001/chrome/browser/ui/app_li...
> chrome/browser/ui/app_list/start_page_service.cc:570: // TODO(calamity):
Remove
> this log after http://crbug.com/462082 is diagnosed.
> I think this can be left in permanently (so drop this TODO). Unless you really
> think it shouldn't be there.

I'd rather get rid of it if it's unused.

[Matt Giuca, 2015-02-26 05:17:11]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-26 05:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961553002/60001

[commit-bot: I haz the power, 2015-02-26 06:24:50]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-02-26 06:25:25]

Patchset 2 (id:??) landed as
https://crrev.com/04ed07f25bb0dca9e5c309e6ecdd69736520db68
Cr-Commit-Position: refs/heads/master@{#318198}