Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 961553002: Enable right clicking on the applist doodle web contents and log the data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/start_page_service.cc
diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc
index 4df7bbbd343d0e53d48a4f01c8f3e60feca31bb9..2b479c0e3bcdf87f69ac9df3ad7825e2bd68e5b5 100644
--- a/chrome/browser/ui/app_list/start_page_service.cc
+++ b/chrome/browser/ui/app_list/start_page_service.cc
@@ -566,6 +566,15 @@ void StartPageService::DidNavigateMainFrame(
ui_zoom::ZoomController::FromWebContents(contents_.get())->SetZoomLevel(0);
}
+void StartPageService::RenderProcessGone(base::TerminationStatus status) {
+ // TODO(calamity): Remove this log after http://crbug.com/462082 is diagnosed.
Matt Giuca 2015/02/26 04:34:55 I think this can be left in permanently (so drop t
+ if (status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION ||
+ status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED ||
+ status == base::TERMINATION_STATUS_PROCESS_CRASHED) {
+ LOG(WARNING) << "App list doodle contents crashed with status " << status;
+ }
+}
+
void StartPageService::WebUILoaded() {
// There's a race condition between the WebUI loading, and calling its JS
// functions. Specifically, calling LoadContents() doesn't mean that the page
« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698