Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/net/net_error_page_controller.cc
diff --git a/chrome/renderer/net/net_error_page_controller.cc b/chrome/renderer/net/net_error_page_controller.cc
index 8a16a557d5c94de5adb7c5194627fc2dd534ce97..c297a5ae4e61d192b04e95499a43c1e5a25b69e5 100644
--- a/chrome/renderer/net/net_error_page_controller.cc
+++ b/chrome/renderer/net/net_error_page_controller.cc
@@ -36,14 +36,14 @@ void NetErrorPageController::Install(content::RenderFrame* render_frame) {
controller.ToV8());
}
-bool NetErrorPageController::LoadStaleButtonClick() {
+bool NetErrorPageController::ShowSavedCopyButtonClick() {
if (!render_frame())
return false;
NetErrorHelper* net_error_helper =
content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame());
DCHECK(net_error_helper);
- net_error_helper->LoadStaleButtonPressed();
+ net_error_helper->ShowSavedCopyButtonPressed();
return true;
}
@@ -95,8 +95,8 @@ gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
v8::Isolate* isolate) {
return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder(
isolate)
- .SetMethod("loadStaleButtonClick",
- &NetErrorPageController::LoadStaleButtonClick)
+ .SetMethod("showSavedCopyButtonClick",
+ &NetErrorPageController::ShowSavedCopyButtonClick)
.SetMethod("reloadButtonClick",
&NetErrorPageController::ReloadButtonClick)
.SetMethod("detailsButtonClick",
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698