Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/renderer/net/net_error_page_controller.cc

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/net/net_error_page_controller.h" 5 #include "chrome/renderer/net/net_error_page_controller.h"
6 6
7 #include "base/strings/string_piece.h" 7 #include "base/strings/string_piece.h"
8 #include "chrome/renderer/net/net_error_helper.h" 8 #include "chrome/renderer/net/net_error_helper.h"
9 #include "content/public/renderer/render_frame.h" 9 #include "content/public/renderer/render_frame.h"
10 #include "gin/handle.h" 10 #include "gin/handle.h"
(...skipping 18 matching lines...) Expand all
29 gin::Handle<NetErrorPageController> controller = gin::CreateHandle( 29 gin::Handle<NetErrorPageController> controller = gin::CreateHandle(
30 isolate, new NetErrorPageController(render_frame)); 30 isolate, new NetErrorPageController(render_frame));
31 if (controller.IsEmpty()) 31 if (controller.IsEmpty())
32 return; 32 return;
33 33
34 v8::Handle<v8::Object> global = context->Global(); 34 v8::Handle<v8::Object> global = context->Global();
35 global->Set(gin::StringToV8(isolate, "errorPageController"), 35 global->Set(gin::StringToV8(isolate, "errorPageController"),
36 controller.ToV8()); 36 controller.ToV8());
37 } 37 }
38 38
39 bool NetErrorPageController::LoadStaleButtonClick() { 39 bool NetErrorPageController::ShowSavedCopyButtonClick() {
40 if (!render_frame()) 40 if (!render_frame())
41 return false; 41 return false;
42 42
43 NetErrorHelper* net_error_helper = 43 NetErrorHelper* net_error_helper =
44 content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame()); 44 content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame());
45 DCHECK(net_error_helper); 45 DCHECK(net_error_helper);
46 net_error_helper->LoadStaleButtonPressed(); 46 net_error_helper->ShowSavedCopyButtonPressed();
47 47
48 return true; 48 return true;
49 } 49 }
50 50
51 bool NetErrorPageController::ReloadButtonClick() { 51 bool NetErrorPageController::ReloadButtonClick() {
52 if (!render_frame()) 52 if (!render_frame())
53 return false; 53 return false;
54 54
55 NetErrorHelper* net_error_helper = 55 NetErrorHelper* net_error_helper =
56 content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame()); 56 content::RenderFrameObserverTracker<NetErrorHelper>::Get(render_frame());
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 NetErrorPageController::NetErrorPageController( 89 NetErrorPageController::NetErrorPageController(
90 content::RenderFrame* render_frame) : RenderFrameObserver(render_frame) {} 90 content::RenderFrame* render_frame) : RenderFrameObserver(render_frame) {}
91 91
92 NetErrorPageController::~NetErrorPageController() {} 92 NetErrorPageController::~NetErrorPageController() {}
93 93
94 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder( 94 gin::ObjectTemplateBuilder NetErrorPageController::GetObjectTemplateBuilder(
95 v8::Isolate* isolate) { 95 v8::Isolate* isolate) {
96 return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder( 96 return gin::Wrappable<NetErrorPageController>::GetObjectTemplateBuilder(
97 isolate) 97 isolate)
98 .SetMethod("loadStaleButtonClick", 98 .SetMethod("showSavedCopyButtonClick",
99 &NetErrorPageController::LoadStaleButtonClick) 99 &NetErrorPageController::ShowSavedCopyButtonClick)
100 .SetMethod("reloadButtonClick", 100 .SetMethod("reloadButtonClick",
101 &NetErrorPageController::ReloadButtonClick) 101 &NetErrorPageController::ReloadButtonClick)
102 .SetMethod("detailsButtonClick", 102 .SetMethod("detailsButtonClick",
103 &NetErrorPageController::DetailsButtonClick) 103 &NetErrorPageController::DetailsButtonClick)
104 .SetMethod("trackClick", 104 .SetMethod("trackClick",
105 &NetErrorPageController::TrackClick); 105 &NetErrorPageController::TrackClick);
106 } 106 }
107 107
108 void NetErrorPageController::OnDestruct() {} 108 void NetErrorPageController::OnDestruct() {}
OLDNEW
« no previous file with comments | « chrome/renderer/net/net_error_page_controller.h ('k') | chrome/renderer/resources/neterror.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698