Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5867)

Unified Diff: chrome/browser/about_flags.cc

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 7f41b7f2bcae79c6519c8e376d453503e43fae94..a84421314404967587df7837fcebf0c6e39d9fbb 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -210,6 +210,16 @@ const Experiment::Choice kMaxTilesForInterestAreaChoices[] = {
cc::switches::kMaxTilesForInterestArea, "512"}
};
+const Experiment::Choice kShowSavedCopyChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_PRIMARY,
+ switches::kShowSavedCopy, switches::kEnableShowSavedCopyPrimary },
+ { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_SECONDARY,
+ switches::kShowSavedCopy, switches::kEnableShowSavedCopySecondary },
+ { IDS_FLAGS_DISABLE_SHOW_SAVED_COPY,
+ switches::kShowSavedCopy, switches::kDisableShowSavedCopy }
+};
+
const Experiment::Choice kDefaultTileWidthChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_DEFAULT_TILE_WIDTH_SHORT,
@@ -1202,12 +1212,11 @@ const Experiment kExperiments[] = {
switches::kDisableOfflineAutoReloadVisibleOnly)
},
{
- "enable-offline-load-stale-cache",
- IDS_FLAGS_ENABLE_OFFLINE_LOAD_STALE_NAME,
- IDS_FLAGS_ENABLE_OFFLINE_LOAD_STALE_DESCRIPTION,
+ "show-saved-copy",
+ IDS_FLAGS_SHOW_SAVED_COPY_NAME,
+ IDS_FLAGS_SHOW_SAVED_COPY_DESCRIPTION,
kOsAll,
- ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOfflineLoadStaleCache,
- switches::kDisableOfflineLoadStaleCache)
+ MULTI_VALUE_TYPE(kShowSavedCopyChoices)
},
{
"default-tile-width",
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698