Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 961443002: Three way experiment for "Show saved copy" button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histograms fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT, 203 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT,
204 cc::switches::kMaxTilesForInterestArea, "64"}, 204 cc::switches::kMaxTilesForInterestArea, "64"},
205 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_TALL, 205 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_TALL,
206 cc::switches::kMaxTilesForInterestArea, "128"}, 206 cc::switches::kMaxTilesForInterestArea, "128"},
207 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_GRANDE, 207 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_GRANDE,
208 cc::switches::kMaxTilesForInterestArea, "256"}, 208 cc::switches::kMaxTilesForInterestArea, "256"},
209 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_VENTI, 209 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_VENTI,
210 cc::switches::kMaxTilesForInterestArea, "512"} 210 cc::switches::kMaxTilesForInterestArea, "512"}
211 }; 211 };
212 212
213 const Experiment::Choice kShowSavedCopyChoices[] = {
214 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
215 { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_PRIMARY,
216 switches::kShowSavedCopy, switches::kEnableShowSavedCopyPrimary },
217 { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_SECONDARY,
218 switches::kShowSavedCopy, switches::kEnableShowSavedCopySecondary },
219 { IDS_FLAGS_DISABLE_SHOW_SAVED_COPY,
220 switches::kShowSavedCopy, switches::kDisableShowSavedCopy }
221 };
222
213 const Experiment::Choice kDefaultTileWidthChoices[] = { 223 const Experiment::Choice kDefaultTileWidthChoices[] = {
214 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 224 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
215 { IDS_FLAGS_DEFAULT_TILE_WIDTH_SHORT, 225 { IDS_FLAGS_DEFAULT_TILE_WIDTH_SHORT,
216 switches::kDefaultTileWidth, "128"}, 226 switches::kDefaultTileWidth, "128"},
217 { IDS_FLAGS_DEFAULT_TILE_WIDTH_TALL, 227 { IDS_FLAGS_DEFAULT_TILE_WIDTH_TALL,
218 switches::kDefaultTileWidth, "256"}, 228 switches::kDefaultTileWidth, "256"},
219 { IDS_FLAGS_DEFAULT_TILE_WIDTH_GRANDE, 229 { IDS_FLAGS_DEFAULT_TILE_WIDTH_GRANDE,
220 switches::kDefaultTileWidth, "512"}, 230 switches::kDefaultTileWidth, "512"},
221 { IDS_FLAGS_DEFAULT_TILE_WIDTH_VENTI, 231 { IDS_FLAGS_DEFAULT_TILE_WIDTH_VENTI,
222 switches::kDefaultTileWidth, "1024"} 232 switches::kDefaultTileWidth, "1024"}
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
1195 }, 1205 },
1196 { 1206 {
1197 "enable-offline-auto-reload-visible-only", 1207 "enable-offline-auto-reload-visible-only",
1198 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_VISIBLE_ONLY_NAME, 1208 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_VISIBLE_ONLY_NAME,
1199 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_VISIBLE_ONLY_DESCRIPTION, 1209 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_VISIBLE_ONLY_DESCRIPTION,
1200 kOsAll, 1210 kOsAll,
1201 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOfflineAutoReloadVisibleOnly, 1211 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOfflineAutoReloadVisibleOnly,
1202 switches::kDisableOfflineAutoReloadVisibleOnly) 1212 switches::kDisableOfflineAutoReloadVisibleOnly)
1203 }, 1213 },
1204 { 1214 {
1205 "enable-offline-load-stale-cache", 1215 "show-saved-copy",
1206 IDS_FLAGS_ENABLE_OFFLINE_LOAD_STALE_NAME, 1216 IDS_FLAGS_SHOW_SAVED_COPY_NAME,
1207 IDS_FLAGS_ENABLE_OFFLINE_LOAD_STALE_DESCRIPTION, 1217 IDS_FLAGS_SHOW_SAVED_COPY_DESCRIPTION,
1208 kOsAll, 1218 kOsAll,
1209 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOfflineLoadStaleCache, 1219 MULTI_VALUE_TYPE(kShowSavedCopyChoices)
1210 switches::kDisableOfflineLoadStaleCache)
1211 }, 1220 },
1212 { 1221 {
1213 "default-tile-width", 1222 "default-tile-width",
1214 IDS_FLAGS_DEFAULT_TILE_WIDTH_NAME, 1223 IDS_FLAGS_DEFAULT_TILE_WIDTH_NAME,
1215 IDS_FLAGS_DEFAULT_TILE_WIDTH_DESCRIPTION, 1224 IDS_FLAGS_DEFAULT_TILE_WIDTH_DESCRIPTION,
1216 kOsAll, 1225 kOsAll,
1217 MULTI_VALUE_TYPE(kDefaultTileWidthChoices) 1226 MULTI_VALUE_TYPE(kDefaultTileWidthChoices)
1218 }, 1227 },
1219 { 1228 {
1220 "default-tile-height", 1229 "default-tile-height",
(...skipping 1560 matching lines...) Expand 10 before | Expand all | Expand 10 after
2781 } 2790 }
2782 2791
2783 const Experiment* GetExperiments(size_t* count) { 2792 const Experiment* GetExperiments(size_t* count) {
2784 *count = num_experiments; 2793 *count = num_experiments;
2785 return experiments; 2794 return experiments;
2786 } 2795 }
2787 2796
2788 } // namespace testing 2797 } // namespace testing
2789 2798
2790 } // namespace about_flags 2799 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698