Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 961053004: Rename elapsed-time field in Chromoting log events to session-duration, to align with server-side f… (Closed)

Created:
5 years, 9 months ago by anandc
Modified:
5 years, 9 months ago
Reviewers:
rmsousa, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org, rmsousa, Sriram
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename elapsed-time field in Chromoting log events to session-duration, and record time in seconds, to align with server-side field names and units. BUG=461610 Tested by running run_webapp_unittest.py with these changes; all tests passed. Committed: https://crrev.com/bd907bb661972284eab39dd75fcf5dcd5eb54868 Cr-Commit-Position: refs/heads/master@{#319200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M remoting/webapp/crd/js/log_to_server.js View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/server_log_entry.js View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
anandc
Jamie, could you PTAL? Thank you.
5 years, 9 months ago (2015-03-04 23:43:15 UTC) #3
rmsousa
lgtm
5 years, 9 months ago (2015-03-04 23:45:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/961053004/20001
5 years, 9 months ago (2015-03-05 00:02:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-05 02:58:29 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 02:58:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd907bb661972284eab39dd75fcf5dcd5eb54868
Cr-Commit-Position: refs/heads/master@{#319200}

Powered by Google App Engine
This is Rietveld 408576698