Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: remoting/webapp/crd/js/server_log_entry.js

Issue 961053004: Rename elapsed-time field in Chromoting log events to session-duration, to align with server-side f… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/log_to_server.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/server_log_entry.js
diff --git a/remoting/webapp/crd/js/server_log_entry.js b/remoting/webapp/crd/js/server_log_entry.js
index 02e6feb0d5f0c3330cec2533bdb1c5988d64e206..b7fdd3d625c782c27bca6737461a40b56bf76f6e 100644
--- a/remoting/webapp/crd/js/server_log_entry.js
+++ b/remoting/webapp/crd/js/server_log_entry.js
@@ -47,7 +47,7 @@ remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_TYPE_ = 'signal-strategy-type';
remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_PROGRESS_ =
'signal-strategy-progress';
/** @private */
-remoting.ServerLogEntry.KEY_ELAPSED_TIME_MS_ = 'elapsed-time';
+remoting.ServerLogEntry.KEY_SESSION_DURATION_SECONDS_ = 'session-duration';
/**
@@ -451,14 +451,14 @@ remoting.ServerLogEntry.extractHostDataFrom_ = function(s) {
};
/**
- * Adds a field to this log entry specifying the elapsed time since the start of
- * the session to the current session state.
- * @param {number} elapsedTimeInMs
+ * Adds a field to this log entry specifying the time in seconds since the start
+ * of the session to the current event.
+ * @param {number} sessionDurationInSeconds
*/
-remoting.ServerLogEntry.prototype.addElapsedTimeMs =
- function(elapsedTimeInMs) {
- this.set_(remoting.ServerLogEntry.KEY_ELAPSED_TIME_MS_,
- String(elapsedTimeInMs));
+remoting.ServerLogEntry.prototype.addSessionDuration =
+ function(sessionDurationInSeconds) {
+ this.set_(remoting.ServerLogEntry.KEY_SESSION_DURATION_SECONDS_,
+ String(sessionDurationInSeconds));
};
« no previous file with comments | « remoting/webapp/crd/js/log_to_server.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698