Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 961053002: Assorted cleanup of RenderLayer. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Assorted cleanup of RenderLayer. -Move perspectiveOrigin to RenderBox. It's only used in one place and called on a RenderBox. -Inline some methods that were just calling out to the renderer. -Inline updateStackingNode() into the constructor and remove the branch since requiresStackingNode is always true. -Delete a bunch of dead code. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f5a6c587991f481e1fbe9098b755f9977f43a349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -179 lines) Patch
M sky/engine/core/rendering/RenderBox.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 3 chunks +13 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 8 chunks +2 lines, -47 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 9 chunks +8 lines, -124 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderTreeAsText.cpp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-26 20:04:29 UTC) #2
ojan
5 years, 10 months ago (2015-02-26 21:07:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5a6c587991f481e1fbe9098b755f9977f43a349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698