Issue 960883003: Fix memory leak in natives-external.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960883003: Fix memory leak in natives-external. (Closed)

Created:
5 years, 10 months ago by vogelheim

Modified:
5 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix memory leak in natives-external. (Discovered when landing crrev.com/959693002) R=jochen@chromium.org BUG= Committed: https://crrev.com/4c80924d2b2f9915f6abbd2ced86f6e90abf8c8e Cr-Commit-Position: refs/heads/master@{#26889}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
M	src/api.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/natives.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/natives-external.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	src/snapshot-empty.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960883003/20001

5 years, 10 months ago (2015-02-26 16:10:04 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 18:33:52 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4c80924d2b2f9915f6abbd2ced86f6e90abf8c8e
Cr-Commit-Position: refs/heads/master@{#26889}