src/api.cc - Issue 960883003: Fix memory leak in natives-external.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 960883003: Fix memory leak in natives-external. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 238c66835d1af1e10c6338f9e3b403a4c19e14fb..daf72e8efa7dc0f8d19af4907c2b8d74a60c3e4f 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -5214,6 +5214,9 @@ void v8::V8::SetArrayBufferAllocator(

bool v8::V8::Dispose() {

i::V8::TearDown();

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+ i::DisposeNatives();

+#endif

return true;

}

« no previous file with comments | « no previous file | src/natives.h » ('j') | no next file with comments »