Add instrumented libraries build with msan

Add instrumented libraries build with msan

BUG=313751
R=glider@chromium.org
TBR=cpu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238394

[alextaran1, 2013-11-29 12:13:39]

Please take a look.

Maybe "sanitizer_type" should be moved to common.gypi?

[alextaran1, 2013-12-03 09:20:26]

On 2013/11/29 12:13:39, alextaran1 wrote:
> Please take a look.
> 
> Maybe "sanitizer_type" should be moved to common.gypi?

ping? :)

[Alexander Potapenko, 2013-12-03 10:23:54]

No need to move "sanitizer_type" to common, since it's used in a single config.

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
File third_party/instrumented_libraries/download_build_install.py (right):

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
third_party/instrumented_libraries/download_build_install.py:15:
SUPPORTED_SANITIZERS = {'asan': 'address', 'msan': 'memory'}
Please modify SUPPORTED_SANITIZERS to allow multiple tool-specific flags and add
origin tracking to 'msan'

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
File third_party/instrumented_libraries/instrumented_libraries.gyp (right):

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
third_party/instrumented_libraries/instrumented_libraries.gyp:35: 'action':
['./fix_rpaths.sh', '<(PRODUCT_DIR)/instrumented_libraries/<(_sanitizer_type)'],
I suggest to wrap this line (see the next comment)

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
File
third_party/instrumented_libraries/standard_instrumented_library_target.gypi
(right):

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
third_party/instrumented_libraries/standard_instrumented_library_target.gypi:19:
'action': ['./download_build_install.py', '-i', '<(PRODUCT_DIR)', '-l',
'<(_target_name)', '-m', '<(INTERMEDIATE_DIR)', '-s', '<(_sanitizer_type)'],
Can you wrap these?
I know we don't have a strict 80-column limit in GYP, but wrapped commandline
parameters are easier to comprehend, e.g.:
./download_build_install.py
-i ...
-l ...
-m ...
-s ...

[alextaran1, 2013-12-03 11:35:47]

Please take another look.

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
File third_party/instrumented_libraries/download_build_install.py (right):

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
third_party/instrumented_libraries/download_build_install.py:15:
SUPPORTED_SANITIZERS = {'asan': 'address', 'msan': 'memory'}
On 2013/12/03 10:23:54, Alexander Potapenko wrote:
> Please modify SUPPORTED_SANITIZERS to allow multiple tool-specific flags and
add
> origin tracking to 'msan'

Done.

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
File third_party/instrumented_libraries/instrumented_libraries.gyp (right):

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
third_party/instrumented_libraries/instrumented_libraries.gyp:35: 'action':
['./fix_rpaths.sh', '<(PRODUCT_DIR)/instrumented_libraries/<(_sanitizer_type)'],
On 2013/12/03 10:23:54, Alexander Potapenko wrote:
> I suggest to wrap this line (see the next comment)

Done.

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
File
third_party/instrumented_libraries/standard_instrumented_library_target.gypi
(right):

https://codereview.chromium.org/96083003/diff/1/third_party/instrumented_libr...
third_party/instrumented_libraries/standard_instrumented_library_target.gypi:19:
'action': ['./download_build_install.py', '-i', '<(PRODUCT_DIR)', '-l',
'<(_target_name)', '-m', '<(INTERMEDIATE_DIR)', '-s', '<(_sanitizer_type)'],
On 2013/12/03 10:23:54, Alexander Potapenko wrote:
> Can you wrap these?
> I know we don't have a strict 80-column limit in GYP, but wrapped commandline
> parameters are easier to comprehend, e.g.:
> ./download_build_install.py
> -i ...
> -l ...
> -m ...
> -s ...

Done.

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
File third_party/instrumented_libraries/download_build_install.py (right):

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/download_build_install.py:15:
SUPPORTED_SANITIZERS = {
Looks like a part of gyp-file. Not sure should this dict be there or in
gyp-file.

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
File
third_party/instrumented_libraries/standard_instrumented_library_target.gypi
(right):

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/standard_instrumented_library_target.gypi:19:
'action': ['./download_build_install.py',
btw, long options are human-readable.

[Alexander Potapenko, 2013-12-03 11:46:46]

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
File third_party/instrumented_libraries/download_build_install.py (right):

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/download_build_install.py:15:
SUPPORTED_SANITIZERS = {
On 2013/12/03 11:35:47, alextaran1 wrote:
> Looks like a part of gyp-file. Not sure should this dict be there or in
> gyp-file.
Yeah, probably. Let us leave it as is and then refactor.

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/download_build_install.py:16: 'asan':
{'compiler_flags': '-fsanitize=address -g -fPIC -w'},
Please use -gline-tables-only instead of -g.

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/download_build_install.py:63:
environment['LDFLAGS'] = '-Wl,-z,origin -Wl,-R,XORIGIN/.'
Aren't you passing -fsanitize=... to the linker?

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
File
third_party/instrumented_libraries/standard_instrumented_library_target.gypi
(right):

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/standard_instrumented_library_target.gypi:19:
'action': ['./download_build_install.py',
Please check whether we need <(DEPTH) here.

[alextaran1, 2013-12-03 12:15:55]

Fixed. Please, take a look again.

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
File third_party/instrumented_libraries/download_build_install.py (right):

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/download_build_install.py:63:
environment['LDFLAGS'] = '-Wl,-z,origin -Wl,-R,XORIGIN/.'
On 2013/12/03 11:46:46, Alexander Potapenko wrote:
> Aren't you passing -fsanitize=... to the linker?

Sorry, my fault, due to http://clang.llvm.org/docs/AddressSanitizer.html program
should be linked with this flag too

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
File
third_party/instrumented_libraries/standard_instrumented_library_target.gypi
(right):

https://codereview.chromium.org/96083003/diff/30001/third_party/instrumented_...
third_party/instrumented_libraries/standard_instrumented_library_target.gypi:19:
'action': ['./download_build_install.py',
On 2013/12/03 11:46:46, Alexander Potapenko wrote:
> Please check whether we need <(DEPTH) here.

Due to
https://code.google.com/p/gyp/wiki/InputFormatReference#Pathname_Relativization

'action' should be fixed but 'inputs' shouldn't

[Alexander Potapenko, 2013-12-03 12:28:33]

LGTM

[commit-bot: I haz the power, 2013-12-03 12:34:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alextaran@chromium.org/96083003/70001

[commit-bot: I haz the power, 2013-12-03 14:33:46]

Change committed as 238394