Add instrumented libraries build with msan

third_party/instrumented_libraries/download_build_install.py

 #!/usr/bin/python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Downloads, builds (with instrumentation) and installs shared libraries."""
 
 import argparse
 import os
 import shutil
 import subprocess
 import sys
 
 # Should be a dict from 'sanitizer type' to 'compiler flag'.
-SUPPORTED_SANITIZERS = {'asan': 'address'}
+SUPPORTED_SANITIZERS = {

[alextaran1, 2013/12/03 11:35:47]

Looks like a part of gyp-file. Not sure should this dict be there or in
gyp-file.

[Alexander Potapenko, 2013/12/03 11:46:46]

Yeah, probably. Let us leave it as is and then refactor.

+  'asan': {'compiler_flags': '-fsanitize=address -g -fPIC -w'},

[Alexander Potapenko, 2013/12/03 11:46:46]

Please use -gline-tables-only instead of -g.

+  'msan': {'compiler_flags':
+    '-fsanitize=memory -fsanitize-memory-track-origins -g -fPIC -w'
+  },
+}
 
 
 class ScopedChangeDirectory(object):
   """Changes current working directory and restores it back automatically."""
   def __init__(self, path):
     self.path = path
     self.old_path = ''
 
   def __enter__(self):
     self.old_path = os.getcwd()
     os.chdir(self.path)
 
   def __exit__(self, exc_type, exc_value, traceback):
     os.chdir(self.old_path)
 
 
 def get_script_absolute_path():
   return os.path.dirname(os.path.abspath(__file__))
 
 
 def get_library_build_dependencies(library):
   command = 'apt-get -s build-dep %s | grep Inst | cut -d " " -f 2' % library
   command_result = subprocess.Popen(command, stdout=subprocess.PIPE,
       shell=True)
+  if command_result.wait():
+    raise Exception("Failed to determine build dependencies for %s" % library)
   build_dependencies = [l.strip() for l in command_result.stdout]
   return build_dependencies
 
 
 def download_build_install(parsed_arguments):
-  sanitizer_flag = SUPPORTED_SANITIZERS[parsed_arguments.sanitizer_type]
+  sanitizer_params = SUPPORTED_SANITIZERS[parsed_arguments.sanitizer_type]
   
   environment = os.environ.copy()
-  environment['CFLAGS'] = '-fsanitize=%s -g -fPIC -w' % sanitizer_flag
-  environment['CXXFLAGS'] = '-fsanitize=%s -g -fPIC -w' % sanitizer_flag
+  environment['CFLAGS'] = sanitizer_params['compiler_flags']
+  environment['CXXFLAGS'] = sanitizer_params['compiler_flags']
   # We use XORIGIN as RPATH and after building library replace it to $ORIGIN
   # The reason: this flag goes through configure script and makefiles
   # differently for different libraries. So the dollar sign '$' should be
   # differently escaped. Instead of having problems with that it just
   # uses XORIGIN to build library and after that replaces it to $ORIGIN
   # directly in .so file.
   environment['LDFLAGS'] = '-Wl,-z,origin -Wl,-R,XORIGIN/.'

[Alexander Potapenko, 2013/12/03 11:46:46]

Aren't you passing -fsanitize=... to the linker?

[alextaran1, 2013/12/03 12:15:55]

Sorry, my fault, due to http://clang.llvm.org/docs/AddressSanitizer.html program
should be linked with this flag too

 
   library_directory = '%s/%s' % (parsed_arguments.intermediate_directory,
       parsed_arguments.library)
   
   install_prefix = '%s/%s/instrumented_libraries/%s' % (
       get_script_absolute_path(),
       parsed_arguments.product_directory,
       parsed_arguments.sanitizer_type)
 
   if not os.path.exists(library_directory):
@@ skipping 55 matching lines @@
     print >> sys.stderr, 'One-liner for APT:'
     print >> sys.stderr, 'sudo apt-get -y --no-remove build-dep %s' % \
         parsed_arguments.library
     sys.exit(1)
 
   download_build_install(parsed_arguments)
 
 
 if __name__ == '__main__':
   main()