Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBarTest.java

Issue 960733002: [Andorid] ClipDrawable progress bar experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBarTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBarTest.java
similarity index 54%
rename from chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
rename to chrome/android/javatests/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBarTest.java
index 7878259524915ecc66b021fff315a5c251077a7a..4a204de8701bf6c0ddf103312d35024b54df8c92 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ClipDrawableProgressBarTest.java
@@ -4,13 +4,10 @@
package org.chromium.chrome.browser.widget;
-import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_PHONE;
-
import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.shell.ChromeShellTestBase;
import org.chromium.chrome.shell.R;
import org.chromium.content.browser.test.util.Criteria;
@@ -21,7 +18,7 @@ import java.util.concurrent.atomic.AtomicReference;
/**
* Tests related to the ToolbarProgressBar.
*/
-public class ToolbarProgressBarTest extends ChromeShellTestBase {
+public class ClipDrawableProgressBarTest extends ChromeShellTestBase {
/**
* Test that calling progressBar.setProgress(# > 0) followed by progressBar.setProgress(0)
* results in a hidden progress bar (the secondary progress needs to be 0).
@@ -29,54 +26,33 @@ public class ToolbarProgressBarTest extends ChromeShellTestBase {
*/
@Feature({"Android-Toolbar"})
@MediumTest
- @Restriction(RESTRICTION_TYPE_PHONE)
public void testProgressBarDisappearsAfterFastShowHide() throws InterruptedException {
launchChromeShellWithUrl("about:blank");
waitForActiveShellToBeDoneLoading();
- final AtomicReference<ToolbarProgressBar> progressBar =
- new AtomicReference<ToolbarProgressBar>();
+ final AtomicReference<ClipDrawableProgressBar> progressBar =
+ new AtomicReference<ClipDrawableProgressBar>();
ThreadUtils.runOnUiThread(new Runnable() {
@Override
public void run() {
- progressBar.set((ToolbarProgressBar) getActivity().findViewById(R.id.progress));
+ progressBar.set(
+ (ClipDrawableProgressBar) getActivity().findViewById(R.id.progress));
}
});
- // Wait for the progress bar to be reset.
+ // Make sure that there is some progress.
CriteriaHelper.pollForUIThreadCriteria(new Criteria() {
@Override
public boolean isSatisfied() {
- return progressBar.get().getProgress() == 0;
- }
- });
-
- ThreadUtils.runOnUiThread(new Runnable() {
- @Override
- public void run() {
- assertEquals("Progress bar should be hidden to start.", 0,
- progressBar.get().getProgress());
- progressBar.get().setProgress(10);
- assertTrue("Progress bar did not start animating",
- progressBar.get().isAnimatingForShowOrHide());
- progressBar.get().setProgress(0);
+ return progressBar.get().getProgress() > 0;
}
});
- // Wait for the progress bar to finish any and all animations.
+ // Wait for the progress bar to be reset.
CriteriaHelper.pollForUIThreadCriteria(new Criteria() {
@Override
public boolean isSatisfied() {
- return !progressBar.get().isAnimatingForShowOrHide();
- }
- });
-
- ThreadUtils.runOnUiThread(new Runnable() {
- @Override
- public void run() {
- // The secondary progress should be gone.
- assertEquals("Progress bar background still visible.", 0,
- progressBar.get().getSecondaryProgress());
+ return progressBar.get().getProgress() == 0;
}
});
}

Powered by Google App Engine
This is Rietveld 408576698