Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 960493003: Remove JITCodeEvent::CODE_REMOVED (Closed)

Created:
5 years, 10 months ago by wingo
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove JITCodeEvent::CODE_REMOVED Instead, JitCodeEventHandlers should remember which ranges they have added, and evict stale entries in the CODE_ADDED or CODE_MOVED event handlers. R=mstarzinger@chromium.org BUG=v8:3918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -101 lines) Patch
M include/v8.h View 3 chunks +4 lines, -7 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/cpu-profiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gdb-jit.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/log.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/log.cc View 7 chunks +0 lines, -42 lines 0 comments Download
M src/perf-jit.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/perf-jit.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/third_party/vtune/vtune-jit.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-sampler-api.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wingo
This patch removes the unused JITCodeEvent::CODE_REMOVED event from the API, and removes the CodeDeletedEvent from ...
5 years, 10 months ago (2015-02-25 11:56:38 UTC) #1
Michael Starzinger
In general I like this cleanup (as it mostly removes code that has been broken ...
5 years, 10 months ago (2015-02-25 15:27:16 UTC) #3
Michael Starzinger
I talked to Sven about this a bit: He convinced me that the protocol is ...
5 years, 10 months ago (2015-02-25 15:46:24 UTC) #5
wingo
5 years, 9 months ago (2015-03-17 15:59:21 UTC) #6
Message was sent while issue was closed.
Closed issue, as I don't need the patch any more and it seems CODE_REMOVED could
be useful as per http://code.google.com/p/v8/issues/detail?id=3918.

Powered by Google App Engine
This is Rietveld 408576698