Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/log.cc

Issue 960493003: Remove JITCodeEvent::CODE_REMOVED (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.h ('k') | src/perf-jit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 924079863b11afaa1610e0bc81684ec5ed734463..a88c037a52d18f797cfb7c4c898bf486d47e7b47 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -236,7 +236,6 @@ class PerfBasicLogger : public CodeEventLogger {
virtual void CodeMoveEvent(Address from, Address to) { }
virtual void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) { }
- virtual void CodeDeleteEvent(Address from) { }
private:
virtual void LogRecordedBuffer(Code* code,
@@ -304,7 +303,6 @@ class LowLevelLogger : public CodeEventLogger {
virtual void CodeMoveEvent(Address from, Address to);
virtual void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) { }
- virtual void CodeDeleteEvent(Address from);
virtual void SnapshotPositionEvent(Address addr, int pos);
virtual void CodeMovingGCEvent();
@@ -332,13 +330,6 @@ class LowLevelLogger : public CodeEventLogger {
};
- struct CodeDeleteStruct {
- static const char kTag = 'D';
-
- Address address;
- };
-
-
struct SnapshotPositionStruct {
static const char kTag = 'P';
@@ -442,13 +433,6 @@ void LowLevelLogger::CodeMoveEvent(Address from, Address to) {
}
-void LowLevelLogger::CodeDeleteEvent(Address from) {
- CodeDeleteStruct event;
- event.address = from + Code::kHeaderSize;
- LogWriteStruct(event);
-}
-
-
void LowLevelLogger::SnapshotPositionEvent(Address addr, int pos) {
SnapshotPositionStruct event;
event.address = addr + Code::kHeaderSize;
@@ -480,7 +464,6 @@ class JitLogger : public CodeEventLogger {
virtual void CodeMoveEvent(Address from, Address to);
virtual void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) { }
- virtual void CodeDeleteEvent(Address from);
virtual void AddCodeLinePosInfoEvent(
void* jit_handler_data,
int pc_offset,
@@ -545,17 +528,6 @@ void JitLogger::CodeMoveEvent(Address from, Address to) {
}
-void JitLogger::CodeDeleteEvent(Address from) {
- Code* from_code = Code::cast(HeapObject::FromAddress(from));
-
- JitCodeEvent event;
- event.type = JitCodeEvent::CODE_REMOVED;
- event.code_start = from_code->instruction_start();
- event.code_len = from_code->instruction_size();
-
- code_event_handler_(&event);
-}
-
void JitLogger::AddCodeLinePosInfoEvent(
void* jit_handler_data,
int pc_offset,
@@ -1343,20 +1315,6 @@ void Logger::CodeMoveEvent(Address from, Address to) {
}
-void Logger::CodeDeleteEvent(Address from) {
- PROFILER_LOG(CodeDeleteEvent(from));
-
- if (!is_logging_code_events()) return;
- CALL_LISTENERS(CodeDeleteEvent(from));
-
- if (!FLAG_log_code || !log_->IsEnabled()) return;
- Log::MessageBuilder msg(log_);
- msg.Append("%s,", kLogEventsNames[CODE_DELETE_EVENT]);
- msg.AppendAddress(from);
- msg.WriteToLogFile();
-}
-
-
void Logger::CodeLinePosInfoAddPositionEvent(void* jit_handler_data,
int pc_offset,
int position) {
« no previous file with comments | « src/log.h ('k') | src/perf-jit.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698