Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 960483002: Implement compositing bounds in CompositingDisplayItem (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
ajuma, chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, dglazkov+blink, Dominik Röttsches, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement compositing bounds in CompositingDisplayItem This patch implements compositing bounds and plumbs them through to cc. With this patch we pass the following additional tests: LayoutTests/svg/zoom/page/zoom-mask-with-percentages.svg LayoutTests/svg/transforms/text-with-mask-with-svg-transform.svg LayoutTests/svg/custom/absolute-sized-content-with-resources.xhtml LayoutTests/svg/custom/mask-excessive-malloc.svg LayoutTests/svg/batik/masking/maskRegions.svg Because there are only a few new passing tests I would like to wait until clipping is supported to add any of these directories to our virtual test suite. This patch depends on the following chromium-side patch: https://codereview.chromium.org/952123002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190876

Patch Set 1 #

Patch Set 2 : Rebase from space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M Source/core/paint/CompositingRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/CompositingRecorder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/paint/CompositingDisplayItem.h View 2 chunks +8 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/CompositingDisplayItem.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M public/platform/WebDisplayItemList.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pdr.
5 years, 10 months ago (2015-02-25 18:27:49 UTC) #2
ajuma
lgtm
5 years, 10 months ago (2015-02-25 18:35:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960483002/1
5 years, 10 months ago (2015-02-25 22:35:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960483002/20001
5 years, 10 months ago (2015-02-25 23:19:20 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 01:48:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190876

Powered by Google App Engine
This is Rietveld 408576698