Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 952123002: Add layer bounds to compositing_dislay_item (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layer bounds to compositing_dislay_item This patch adds an SkRect for bounds to compositing_display_item and uses it for setting the canvas layer bounds. With this patch and the associated blink-side patch [1] we pass the following additional layout tests: LayoutTests/svg/zoom/page/zoom-mask-with-percentages.svg LayoutTests/svg/transforms/text-with-mask-with-svg-transform.svg LayoutTests/svg/custom/absolute-sized-content-with-resources.xhtml LayoutTests/svg/custom/mask-excessive-malloc.svg LayoutTests/svg/batik/masking/maskRegions.svg [1] https://codereview.chromium.org/960483002 Committed: https://crrev.com/18fc53626c407d76c22c91132cabaa7a0923ed62 Cr-Commit-Position: refs/heads/master@{#318127}

Patch Set 1 #

Patch Set 2 : Make this landable with only 3 patches #

Patch Set 3 : Remove implicit pointer to bool conversion #

Total comments: 1

Patch Set 4 : !!bounds! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M cc/blink/web_display_item_list_impl.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M cc/resources/compositing_display_item.h View 3 chunks +6 lines, -1 line 0 comments Download
M cc/resources/compositing_display_item.cc View 1 2 3 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
pdr.
5 years, 10 months ago (2015-02-25 06:16:47 UTC) #2
pdr.
5 years, 10 months ago (2015-02-25 06:26:16 UTC) #3
ajuma
lgtm
5 years, 10 months ago (2015-02-25 14:22:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952123002/20001
5 years, 10 months ago (2015-02-25 18:27:38 UTC) #6
pdr.
On 2015/02/25 at 18:27:38, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 10 months ago (2015-02-25 20:42:43 UTC) #7
ajuma
https://codereview.chromium.org/952123002/diff/40001/cc/resources/compositing_display_item.cc File cc/resources/compositing_display_item.cc (right): https://codereview.chromium.org/952123002/diff/40001/cc/resources/compositing_display_item.cc#newcode22 cc/resources/compositing_display_item.cc:22: has_bounds_(bounds != nullptr), The usual pattern to workaround that ...
5 years, 10 months ago (2015-02-25 20:44:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952123002/40001
5 years, 10 months ago (2015-02-25 20:44:52 UTC) #11
pdr.
On 2015/02/25 at 20:44:30, ajuma wrote: > https://codereview.chromium.org/952123002/diff/40001/cc/resources/compositing_display_item.cc > File cc/resources/compositing_display_item.cc (right): > > https://codereview.chromium.org/952123002/diff/40001/cc/resources/compositing_display_item.cc#newcode22 ...
5 years, 10 months ago (2015-02-25 20:56:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952123002/60001
5 years, 10 months ago (2015-02-25 20:57:54 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-25 22:29:33 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 22:45:00 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/18fc53626c407d76c22c91132cabaa7a0923ed62
Cr-Commit-Position: refs/heads/master@{#318127}

Powered by Google App Engine
This is Rietveld 408576698