Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: src/lookup.cc

Issue 960343002: ES6: Make function name configurable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Relax assert Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index b629f1980cac6c080c323766167295b46efe55f1..47dd361279b87731b4a493baea4ea81b8ad09fe8 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -313,7 +313,7 @@ Handle<Object> LookupIterator::GetDataValue() const {
Handle<Object> LookupIterator::WriteDataValue(Handle<Object> value) {
- DCHECK_EQ(DATA, state_);
+ DCHECK(DATA == state_ || ACCESSOR == state_);
arv (Not doing code reviews) 2015/02/26 22:30:37 Toon, this cannot be right. What is the right way
Toon Verwaest 2015/02/27 12:44:10 This isn't right indeed. Are you sure you need thi
Handle<JSObject> holder = GetHolder<JSObject>();
if (holder_map_->is_dictionary_map()) {
NameDictionary* property_dictionary = holder->property_dictionary();

Powered by Google App Engine
This is Rietveld 408576698