ES6: Make function name configurable

src/lookup.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/bootstrapper.h"
 #include "src/deoptimizer.h"
 #include "src/lookup.h"
 #include "src/lookup-inl.h"
@@ skipping 295 matching lines @@
 
 
 Handle<Object> LookupIterator::GetDataValue() const {
   DCHECK_EQ(DATA, state_);
   Handle<Object> value = FetchValue();
   return value;
 }
 
 
 Handle<Object> LookupIterator::WriteDataValue(Handle<Object> value) {
-  DCHECK_EQ(DATA, state_);
+  DCHECK(DATA == state_ || ACCESSOR == state_);

[arv (Not doing code reviews), 2015/02/26 22:30:37]

Toon, this cannot be right.

What is the right way to replace an accessor with a data property?

[Toon Verwaest, 2015/02/27 12:44:10]

This isn't right indeed. Are you sure you need this? it.PrepareForDataProperty()
should have reconfigured and reloaded the propertyinfo, so you should be in
state_ == DATA by the time you SetDataProperty.

   Handle<JSObject> holder = GetHolder<JSObject>();
   if (holder_map_->is_dictionary_map()) {
     NameDictionary* property_dictionary = holder->property_dictionary();
     if (holder->IsGlobalObject()) {
       Handle<PropertyCell> cell(
           PropertyCell::cast(property_dictionary->ValueAt(dictionary_entry())));
       value = PropertyCell::SetValueInferType(cell, value);
     } else {
       property_dictionary->ValueAtPut(dictionary_entry(), *value);
     }
@@ skipping 26 matching lines @@
   }
   return false;
 }
 
 
 void LookupIterator::InternalizeName() {
   if (name_->IsUniqueName()) return;
   name_ = factory()->InternalizeString(Handle<String>::cast(name_));
 }
 } }  // namespace v8::internal