Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 960263003: Fix the order of experimenal global init/natives installation. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the order of experimenal global init/natives installation. Just like for normal natives, we need to initialize the global object first and install natives afterwards. R=rossberg@chromium.org

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 9 months ago (2015-03-03 16:25:10 UTC) #1
rossberg
lgtm
5 years, 9 months ago (2015-03-03 18:20:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960263003/1
5 years, 9 months ago (2015-03-04 14:11:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3424)
5 years, 9 months ago (2015-03-04 14:12:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960263003/20001
5 years, 9 months ago (2015-03-04 15:29:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/479)
5 years, 9 months ago (2015-03-04 15:44:17 UTC) #11
Dmitry Lomov (no reviews)
5 years, 9 months ago (2015-03-12 14:34:36 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698