Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 960263002: Update references to ICU 5.2 in README.chromium to 5.4 (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update references to ICU 5.2 in README.chromium to 5.4 R=jshin@chromium.org BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M README.chromium View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-26 15:11:20 UTC) #1
jochen (gone - plz use gerrit)
I tried and failed to build the windows dll using those instructions. could you build ...
5 years, 10 months ago (2015-02-26 15:39:14 UTC) #3
jochen (gone - plz use gerrit)
the failure is 28> Building icu data from E:\src\icu54\source\data\in\icudt54l.dat 28> cd "E:\src\icu54\source\data\out\build\icudt54l" 28> "E:\src\icu54\bin\icupkg" -x ...
5 years, 10 months ago (2015-02-26 15:45:56 UTC) #4
jungshik at Google
On 2015/02/26 15:45:56, jochen (traveling) wrote: > the failure is > > 28> Building icu ...
5 years, 9 months ago (2015-03-02 06:52:13 UTC) #5
jungshik at Google
5 years, 9 months ago (2015-03-02 09:04:49 UTC) #6
On 2015/03/02 06:52:13, Jungshik at google wrote:
> On 2015/02/26 15:45:56, jochen (traveling) wrote:
> > the failure is
> > 
> > 28>  Building icu data from E:\src\icu54\source\data\in\icudt54l.dat
> > 28>  	cd "E:\src\icu54\source\data\out\build\icudt54l"
> > 28>  	"E:\src\icu54\bin\icupkg" -x * --list
> > "E:\src\icu54\source\data\in\icudt54l.dat" >
> > "E:\src\icu54\source\data\out\tmp\icudata.lst"
> > 28>  Item brkitr/en_US_POSIX.res depends on missing item
brkitr/word_POSIX.brk
> > 28>  Item coll/id_ID.res depends on missing item coll/id.res
> > 28>  Item coll/in.res depends on missing item coll/id.res
> > 28>  Item lang/mo.res depends on missing item lang/ro_MD.res
> > 28>NMAKE : fatal error U1077: '"E:\src\icu54\bin\icupkg"' : return code
'0x2'
> > 28>  Stop.
> 
> Thank you for catching them. I know the causes of those errors. 
> I'll fix them.

See https://codereview.chromium.org/962643003/

Powered by Google App Engine
This is Rietveld 408576698