Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: README.chromium

Issue 960263002: Update references to ICU 5.2 in README.chromium to 5.4 (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
diff --git a/README.chromium b/README.chromium
index b9b9662ce9f65153b428b1ab8a228bdff0177867..bacaa3c348e7f4dcaaf9731ff29e194aa9b01a8f 100644
--- a/README.chromium
+++ b/README.chromium
@@ -194,15 +194,15 @@ This directory contains the source code of ICU 54.1 for C/C++.
- source/data/in/icudtl.dat : Built on Linux with all the patches
- above applied. icudt52l.dat is generated in
+ above applied. icudt54l.dat is generated in
{BUILD_DIR_ROOT}/data/out/tmp and copied to the above location with a
- version number (52) dropped.
+ version number (54) dropped.
- {mac,linux}/icudtl_dat.S : Built on Linux with all the
patches above (except android/brkitr.patch) applied and checked in.
This file will be generated in {BUILD_DIR_ROOT}/data/out/tmp as
- icudt52l_dat.S, but '52' is dropped while copying.
+ icudt54l_dat.S, but '54' is dropped while copying.
mac/icudtl_dat.S is identical to linux/icudtl_dat.S except for
the header portion. With "linux/icudtl_dat.S" in its place,
@@ -210,29 +210,29 @@ This directory contains the source code of ICU 54.1 for C/C++.
- android/icudtl_dat.S : Built on Linux with all the patches above and
android/brkitr.patch applied and android/patch_locale.sh executed.
- '52' is dropped from the name generated in the build tree.
+ '54' is dropped from the name generated in the build tree.
- - android/icudtl.dat : Generated as icudt52l.dat in
- {BUILD_DIR_ROOT}/data/out/tmp along with icudt52l_dat.S and
- copied to the above location with '52' dropped in its name.
+ - android/icudtl.dat : Generated as icudt54l.dat in
+ {BUILD_DIR_ROOT}/data/out/tmp along with icudt54l_dat.S and
+ copied to the above location with '54' dropped in its name.
- windows/icudt.dll (by default, we set icu_use_icu_data_flag to 1
and don't use this file.)
- a. check out a clean copy of icu52 from the upstream on Windows
+ a. check out a clean copy of icu54 from the upstream on Windows
outside the Chrome tree.
- $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tags/release-52-1 ${SEPARATE_ICU_ROOT}/icu52
+ $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tags/release-54-1 ${SEPARATE_ICU_ROOT}/icu54
b. copy ${CHROME_ICU_ROOT}/source/data/in/icudtl.dat to
- ${SEPARATE_ICU_ROOT}/source/data/in/icudt52l.dat
+ ${SEPARATE_ICU_ROOT}/source/data/in/icudt54l.dat
c. copy ${CHROME_ICU_ROOT}/source/data/makedata.mak to
${SEPARATE_ICU_ROOT}/source/data/makedata.mak
c. In Visual Studio, open source/allinone/allinone.sln solution
in ${SEPARATE_ICU_ROOT}
d. Build 'makedata' target
- e. icudt52.dll will be generated in ${SEPARATE_ICU_ROOT}/bin
- f. Copy that icudt52.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
+ e. icudt54.dll will be generated in ${SEPARATE_ICU_ROOT}/bin
+ f. Copy that icudt54.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
and check that in.
10. Apply the following patches for regex
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698