Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 960183004: Upgrade openjpeg to revision 2997. (Closed)

Created:
5 years, 10 months ago by jun_fang
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -139 lines) Patch
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/bio.c View 4 chunks +3 lines, -6 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/j2k.c View 9 chunks +28 lines, -14 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c View 10 chunks +28 lines, -18 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/mct.c View 6 chunks +230 lines, -2 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/openjpeg.h View 1 chunk +30 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_includes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/opj_intmath.h View 4 chunks +24 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/pi.c View 2 chunks +9 lines, -4 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.h View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t1.c View 8 chunks +17 lines, -11 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c View 1 chunk +2 lines, -2 lines 1 comment Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/tcd.h View 2 chunks +9 lines, -8 lines 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/tcd.c View 23 chunks +98 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jun_fang
Hi Tom and Lei, Recently, some openjpeg issues were opened in pdfium. Most of them ...
5 years, 10 months ago (2015-02-26 19:27:11 UTC) #2
Tom Sepez
https://codereview.chromium.org/960183004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c (right): https://codereview.chromium.org/960183004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c#newcode391 core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c:391: Looks like this file is whitespace only. Did they ...
5 years, 10 months ago (2015-02-26 22:58:03 UTC) #3
jun_fang
On 2015/02/26 22:58:03, Tom Sepez wrote: > https://codereview.chromium.org/960183004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c > File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c (right): > > https://codereview.chromium.org/960183004/diff/1/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c#newcode391 ...
5 years, 10 months ago (2015-02-27 00:28:04 UTC) #4
Tom Sepez
On 2015/02/27 00:28:04, jun_fang wrote: > On 2015/02/26 22:58:03, Tom Sepez wrote: > > > ...
5 years, 9 months ago (2015-02-27 17:56:12 UTC) #5
jun_fang
5 years, 9 months ago (2015-02-27 18:00:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec61a859344dc6d2a60e4cbcd1555e6d317f2add (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698