Correctly handle tab navigation in the app list.

Correctly handle tab navigation in the app list.

This CL causes the app list tab navigation to correctly cycle to and from
the custom launcher page. This has been fixed by adding a SearchBoxFocusHost
which directs the focus search to the search box.

BUG=462079
Committed: https://crrev.com/a4e2242b75647b641e6d2190b01cde7c9c5233c8
Cr-Commit-Position: refs/heads/master@{#318814}

[calamity, 2015-02-27 05:41:03]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-02-27 06:29:38]

lgtm with some more explanative comments.

https://codereview.chromium.org/960133005/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/960133005/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view.cc:86: // This view forwards the focus to the
search box widget by providing its
"its" -> "it as a"

https://codereview.chromium.org/960133005/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view.cc:486: // Set up search box widget focus.
// The search box will not naturally receive focus by itself (because it is in a
separate widget). Create this SearchBoxFocusHost in the main widget to receive
focus, and forward its focus to the search box.

[calamity, 2015-03-02 03:34:52]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org

[calamity, 2015-03-02 03:34:53]

+benwells for c/b/apps.

https://codereview.chromium.org/960133005/diff/20001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view.cc (right):

https://codereview.chromium.org/960133005/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view.cc:86: // This view forwards the focus to the
search box widget by providing its
On 2015/02/27 06:29:38, Matt Giuca wrote:
> "its" -> "it as a"

Done.

https://codereview.chromium.org/960133005/diff/20001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view.cc:486: // Set up search box widget focus.
On 2015/02/27 06:29:38, Matt Giuca wrote:
> // The search box will not naturally receive focus by itself (because it is in
a
> separate widget). Create this SearchBoxFocusHost in the main widget to receive
> focus, and forward its focus to the search box.

Reworded the end of the sentence since the SBFH never actually gets focused, it
just forwards the focus search to the search box widget.

[calamity, 2015-03-02 03:34:58]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-03-02 03:34:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/960133005/#ps40001 (title:
"address comments")

[commit-bot: I haz the power, 2015-03-02 03:35:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960133005/40001

[commit-bot: I haz the power, 2015-03-02 03:51:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 03:51:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[benwells, 2015-03-02 06:06:11]

stamp lgtm

[calamity, 2015-03-03 00:44:37]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-03-03 00:45:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960133005/40001

[commit-bot: I haz the power, 2015-03-03 01:40:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-03 01:40:48]

Patchset 3 (id:??) landed as
https://crrev.com/a4e2242b75647b641e6d2190b01cde7c9c5233c8
Cr-Commit-Position: refs/heads/master@{#318814}

[Dirk Pranke, 2015-03-06 00:04:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/986513002/ by dpranke@chromium.org.

The reason for reverting is: The new test appears to be flaky, unfortunately:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Cus...

.

[Matt Giuca, 2015-03-06 00:27:58]

This was not reverted. Instead, the test was disabled first on ChromeOS:
https://codereview.chromium.org/973793003
then everywhere:
https://codereview.chromium.org/985563002

Follow up in http://crbug.com/463456.